fix(sqllab): add colorEditorSelection token for visible text selection

gabotorresruiz · gabotorresruiz · commit 8d2abc258f20 · 2026-01-06T18:38:21.000-04:00
diff --git a/superset-frontend/packages/superset-core/src/ui/theme/types.ts b/superset-frontend/packages/superset-core/src/ui/theme/types.ts
@@ -159,6 +159,13 @@ export interface SupersetSpecificTokens {
   echartsOptionsOverridesByChartType?: {
     [chartType: string]: any;
   };
+
+  // Editor-related
+  /**
+   * Background color for code editor text selection.
+   * Defaults to colorPrimaryBgHover if not specified.
+   */
+  colorEditorSelection?: string;
 }
 
 /**
diff --git a/superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx b/superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx
@@ -294,7 +294,8 @@ export function AsyncAceEditor(
                 }
                 /* Adjust selection color */
                 .ace_editor .ace_selection {
-                  background-color: ${token.colorPrimaryBgHover} !important;
+                  background-color: ${token.colorEditorSelection ??
+                  token.colorPrimaryBgHover} !important;
                 }
 
                 /* Improve active line highlighting */

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,8 @@ export function AsyncAceEditor(`
`294`	`294`	`}`
`295`	`295`	`/* Adjust selection color */`
`296`	`296`	`.ace_editor .ace_selection {`
`297`		`- background-color: ${token.colorPrimaryBgHover} !important;`
	`297`	`+ background-color: ${token.colorEditorSelection ??`
	`298`	`+ token.colorPrimaryBgHover} !important;`
`298`	`299`	`}`
`299`	`300`
`300`	`301`	`/* Improve active line highlighting */`