From 08145d88b95d37c034fc939ddbc37d1bab727e5e Mon Sep 17 00:00:00 2001 From: Sam Firke Date: Wed, 18 Sep 2024 15:18:42 -0400 Subject: [PATCH] style(explore): clarify ambiguously named "sort by" field (#30254) --- .../src/shared-controls/dndControls.tsx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx index 96124d6c67680..130478893ef41 100644 --- a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx +++ b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx @@ -188,11 +188,12 @@ export const dndSortByControl: SharedControlConfig< 'DndMetricSelect' | 'MetricsControl' > = { type: 'DndMetricSelect', - label: t('Sort by'), + label: t('Sort query by'), default: null, description: t( - 'This metric is used to define row selection criteria (how the rows are sorted) if a series or row limit is present. ' + - 'If not defined, it reverts to the first metric (where appropriate).', + 'Orders the query result that generates the source data for this chart. ' + + 'If a series or row limit is reached, this determines what data are truncated. ' + + 'If undefined, defaults to the first metric (where appropriate).', ), mapStateToProps: ({ datasource }) => ({ columns: datasource?.columns || [],