[BUG] divide plugin config lost when network has problem

[NightliarX]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

when the network experiences jitter,the ip:port configuration in divide plugin will be lost

Expected Behavior

do not change divide plugin's configuration even the network is unreachable，because network jitter will recover soon

Steps To Reproduce

1.click pluginList-proxy-divide-add,to add a new divide config
2,in this config,Ip:port set a Ip address that unreachable
3.save this config
4.click modify button to see Ip:port config

Environment

ShenYu version(s):2.5.1

Debug logs

No response

Anything else?

No response

[NightliarX]

after reading the code ,I found that the code in org.apache.shenyu.admin.service.impl.UpstreamCheckService may have concurrency problem.
UPSTREAM_MAP.get(selectorId) in first picture may execute before updateHandler in method submit was executed.it leads to an error result after updated the database(updateHandler's update result in first picture will cover the update result in second picture)

[NightliarX]

and I dont understand why shenyu-admin would update database after the network changes,I dont think it is a good design.shenyu-admin can do this operation and publish event in memory,but update datebase makes me very confusing and it occures problem

I losed almost all ip:port in divide configs after the jitter and it cannot recover automaticaly because of this bug,that's a very serious problem.

[moremind]

yeah, shenyu will refactor the design, and keep the database, now, you can config shenyu.register.props.checked=false

[loongs-zhang]

@NightliarX Hi, I recommend increasing the value of shenyu.register.props.zombieCheckTimes.

As for concurrency problem, see #5587 , the PR also fix other bug.