Skip to content

Commit 5a81a9c

Browse files
committed
changes per review
1 parent 7b744ef commit 5a81a9c

File tree

1 file changed

+6
-7
lines changed
  • extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc

1 file changed

+6
-7
lines changed

extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,12 @@ public void executeScript(String scriptFilePath) throws SQLException {
9494
* Executes SELECT Query and returns the results after applying a transformer
9595
*
9696
* @param query : Query to executed
97-
* @param converterInstance : An entity of the type being selected, used to convert to
98-
* PolarisBaseEntity
97+
* @param converterInstance : An instance of the type being selected, used to convert to
98+
* a business entity like PolarisBaseEntity
99+
* @param transformer Transformation of entity class to Result class
99100
* @return The list of results yielded by the query
100-
* @param <T> : Entity class
101-
* @param <R> : Result class
101+
* @param <T> : Persistence entity class
102+
* @param <R> : Business entity class
102103
* @throws SQLException : Exception during the query execution.
103104
*/
104105
public <T, R> List<R> executeSelect(
@@ -110,9 +111,7 @@ public <T, R> List<R> executeSelect(
110111
executeSelectOverStream(
111112
query,
112113
converterInstance,
113-
stream -> {
114-
stream.map(transformer).forEach(results::add);
115-
});
114+
stream -> stream.map(transformer).forEach(results::add););
116115
return results;
117116
}
118117

0 commit comments

Comments
 (0)