From fdad7e14081dee0046556e1c4d848039afcd522b Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Thu, 28 Sep 2023 22:35:00 +0000 Subject: [PATCH] [github-523] set locales for some tests. This closes #523 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912583 13f79535-47bb-0310-9956-ffa450edef68 --- .../poi/xssf/usermodel/TestXSSFWorkbook.java | 13 +++++++++++++ .../apache/poi/ss/formula/functions/TestDays.java | 14 ++++++++++++++ .../poi/ss/usermodel/BaseTestDataFormat.java | 14 ++++++++++++++ 3 files changed, 41 insertions(+) diff --git a/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java b/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java index 10ccde01fab..8f1ad227f66 100644 --- a/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java +++ b/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java @@ -61,6 +61,8 @@ Licensed to the Apache Software Foundation (ASF) under one or more import org.apache.poi.xddf.usermodel.chart.XDDFChartData; import org.apache.poi.xssf.XSSFITestDataProvider; import org.apache.poi.xssf.model.StylesTable; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTCalcPr; import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTExternalLink; @@ -79,6 +81,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more import java.util.Date; import java.util.Iterator; import java.util.List; +import java.util.Locale; import java.util.zip.CRC32; import static org.apache.poi.hssf.HSSFTestDataSamples.openSampleFileStream; @@ -100,6 +103,16 @@ public TestXSSFWorkbook() { super(XSSFITestDataProvider.instance); } + @BeforeAll + static void setUp() { + LocaleUtil.setUserLocale(Locale.US); + } + + @AfterAll + static void tearDown() { + LocaleUtil.setUserLocale(null); + } + /** * Tests that we can save, and then re-load a new document */ diff --git a/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDays.java b/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDays.java index c3b804995a7..fab91e1fd0a 100644 --- a/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDays.java +++ b/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDays.java @@ -23,10 +23,14 @@ Licensed to the Apache Software Foundation (ASF) under one or more import org.apache.poi.hssf.usermodel.HSSFWorkbook; import org.apache.poi.ss.usermodel.DateUtil; import org.apache.poi.ss.usermodel.FormulaError; +import org.apache.poi.util.LocaleUtil; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; import java.io.IOException; import java.time.LocalDate; +import java.util.Locale; import static org.apache.poi.ss.util.Utils.addRow; import static org.apache.poi.ss.util.Utils.assertDouble; @@ -37,6 +41,16 @@ Licensed to the Apache Software Foundation (ASF) under one or more */ public class TestDays { + @BeforeAll + static void setUp() { + LocaleUtil.setUserLocale(Locale.US); + } + + @AfterAll + static void tearDown() { + LocaleUtil.setUserLocale(null); + } + //https://support.microsoft.com/en-us/office/days-function-57740535-d549-4395-8728-0f07bff0b9df @Test void testMicrosoftExample1() throws IOException { diff --git a/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestDataFormat.java b/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestDataFormat.java index 65ee8ffa49d..eed2fd3cc35 100644 --- a/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestDataFormat.java +++ b/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestDataFormat.java @@ -22,8 +22,12 @@ Licensed to the Apache Software Foundation (ASF) under one or more import static org.junit.jupiter.api.Assertions.assertTrue; import java.io.IOException; +import java.util.Locale; import org.apache.poi.ss.ITestDataProvider; +import org.apache.poi.util.LocaleUtil; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; /** @@ -45,6 +49,16 @@ void assertNotBuiltInFormat(String customFmt) { assertEquals(-1, BuiltinFormats.getBuiltinFormat(customFmt)); } + @BeforeAll + static void setUp() { + LocaleUtil.setUserLocale(Locale.US); + } + + @AfterAll + static void tearDown() { + LocaleUtil.setUserLocale(null); + } + @Test public final void testBuiltinFormats() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) {