While reading through RenewableTlsUtils, it was observed that transient failures during SSL factory reload are logged at the INFO level, which appears inappropriate for a failure path.
Where
pinot-common/src/main/java/org/apache/pinot/common/utils/tls/RenewableTlsUtils.java,
inside reloadSslFactory, around line 304:
} catch (Exception e) {
LOGGER.info(
"reloadSslFactory :: Encountered issues when renewing SSLFactory "
+ "{} (built from key store {} and "
+ "truststore {}) on ", baseSslFactory, keyStorePath, trustStorePath, e);
return false;
}
### Bug
This catch block runs inside a 3-attempt retry loop. It's the only
place each individual retry failure gets logged, and it's at `INFO`
level. The final exhausted-retries log a few lines down is at `ERROR`,
which is correct.
While reading through
RenewableTlsUtils, it was observed that transient failures during SSL factory reload are logged at theINFOlevel, which appears inappropriate for a failure path.Where
pinot-common/src/main/java/org/apache/pinot/common/utils/tls/RenewableTlsUtils.java,inside
reloadSslFactory, around line 304: