You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the PinotJoinToDynamicBroadcastRule is applied even if there's no explicit hint provided. While it's great to have this optimization, it shouldn't be ON by default (at least for Uber.. some other companies may prefer it).
Hence it would be great if we can make it so that this rule doesn't get auto applied for every query.
We can't change the default behavior now I guess since it would be backwards incompatible, so the most natural solution to me is to make it configurable.
QueryEnvironment could pass in the broker config to PinotQueryRuleSets, which can pass the config to the eligible rules.
Forward looking guideline: I think we should only use configurations for rules in exceptional scenarios like this one, since adding complexity to the rule set would make testing harder.
We can assign name to each rule, and allow user to provide a list of excluded rules. In the future we might also want to support an included list of rules which are not included by default.
Currently, the
PinotJoinToDynamicBroadcastRule
is applied even if there's no explicit hint provided. While it's great to have this optimization, it shouldn't be ON by default (at least for Uber.. some other companies may prefer it).Hence it would be great if we can make it so that this rule doesn't get auto applied for every query.
We can't change the default behavior now I guess since it would be backwards incompatible, so the most natural solution to me is to make it configurable.
QueryEnvironment could pass in the broker config to PinotQueryRuleSets, which can pass the config to the eligible rules.
Forward looking guideline: I think we should only use configurations for rules in exceptional scenarios like this one, since adding complexity to the rule set would make testing harder.
cc: @shauryachats
The text was updated successfully, but these errors were encountered: