Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer sbt-osgi for main branch #757

Closed
mdedetrich opened this issue Oct 21, 2023 · 1 comment · Fixed by #920
Closed

Use newer sbt-osgi for main branch #757

mdedetrich opened this issue Oct 21, 2023 · 1 comment · Fixed by #920
Assignees

Comments

@mdedetrich
Copy link
Contributor

mdedetrich commented Oct 21, 2023

With #745 we ended up creating a patched sbt-osgi v0.9.4 which contained the corrupted jar fix that is now used for both main and 1.0.x. While there is a strong argument that for the 1.0.x branch of Pekko we should leave sbt-osgi on 0.9.4-INVALID-CEN-JAR-PATCH indefinitly, for main we ideally should be using the newer sbt-osgi because if we find more issues with sbt-osgi we won't be able to use it until we fix the regression that is now present in the latest version of sbt-osgi. Its better that we nip this in the bud sooner rather than later since we have some breathing space now.

As can be seen at sbt/sbt-osgi#93 (comment), there are apparently fixes for the duplicate classes being placed in the osgi package creating the error described at #745 (comment) so we should apply these fixes + create new releases of sbt-osgi so that we can properly solve the regression as part of sbt/sbt-osgi#93 (comment) .

Pinging @pjfanning @lefou @romainreuillon

@mdedetrich
Copy link
Contributor Author

Did an investigation upstream at sbt/sbt-osgi#102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant