Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate integration-test/marathon-api-docker/build.sbt #28

Open
pjfanning opened this issue Mar 1, 2023 · 4 comments
Open

investigate integration-test/marathon-api-docker/build.sbt #28

pjfanning opened this issue Mar 1, 2023 · 4 comments

Comments

@pjfanning
Copy link
Contributor

pjfanning commented Mar 1, 2023

  • we need to get the pekko jars from testing from MavenLocal repo instead of from official releases
  • we want to test what we've just built
  • see the '1.1.4' version parameter to see what needs to change
  • seems likely that these tests are not running since the current config looks wrong - we should see if we can fix the config and get them running again
@nvollmar
Copy link
Contributor

nvollmar commented Mar 1, 2023

Checking the Readme, the following projects are/were not maintained by Lightbend and were left to the community:

akka-discovery-marathon-api
akka-discovery-aws-api
akka-discovery-aws-api-async
akka-discovery-consul

We might want to discuss how to go forward with them: Drop them, leave them as is or start maintaining them?

@mdedetrich
Copy link
Contributor

I would say if we get the tests running and they pass I don't see a reason to drop them. The distinction between "leave them" and "maintaining them" doesn't seem to really exist now, I think that everything is implicitly by definition maintained unless we decide to remove them (Pekko is a community project by definition from ASF)

@mdedetrich
Copy link
Contributor

mdedetrich commented Mar 1, 2023

On a similar note we should also update the README at https://github.com/apache/incubator-pekko-management#project-status (everything at Pekko is "community", this language is only relevant when it was at Lightbend).

@nvollmar
Copy link
Contributor

nvollmar commented Mar 2, 2023

The marathon integration test projects don't contain any testing code and look more like sample implementations.
The aws integration test project has some sbt project that is missing dependencies to even be loaded.

I'd reword the README to mark them as experimental (at best) and see if there is even interest in them => #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants