Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kinesis] transitive dependency on scala 2.12 jar #479

Open
pjfanning opened this issue Feb 12, 2024 · 3 comments
Open

[kinesis] transitive dependency on scala 2.12 jar #479

pjfanning opened this issue Feb 12, 2024 · 3 comments

Comments

@pjfanning
Copy link
Contributor

pjfanning commented Feb 12, 2024

I'm not sure if there is anything that can be done to fix this but logging for visibility.

Our Kinesis Connector depends on "software.amazon.kinesis:amazon-kinesis-client" and this depends on "com.kjetland:mbknor-jackson-jsonschema_2.12".

com.kjetland:mbknor-jackson-jsonschema_2.12:1.0.39
software.amazon.glue:schema-registry-serde:1.1.17
software.amazon.kinesis:amazon-kinesis-client:2.5.4

This dependency is brought in transitively and is hardcoded as Scala 2.12 - ie it does not adjust to the Scala version used by Pekko users. We could exclude the dependency and add our own dependency on "com.kjetland" %% "mbknor-jackson-jsonschema" but there is no Scala 3 release for this jar.

Basically, "com.kjetland" %% "mbknor-jackson-jsonschema" appears not to be actively supported. It hasn't been released since 2020 and has some old Jackson dependencies.

I can raise an issue at https://github.com/mbknor/mbknor-jackson-jsonSchema

@raboof
Copy link
Member

raboof commented Feb 12, 2024

We could exclude the dependency and add our own dependency on "com.kjetland" %% "mbknor-jackson-jsonschema" but there is no Scala 3 release for this jar.

Could we use CrossVersion.for3Use2_13?

@pjfanning
Copy link
Contributor Author

@jtjeferreira You appear to use the Kinesis connector. Have you run into this issue or do you have any thoughts? Is it possible that we don't use the code in software.amazon.kinesis:amazon-kinesis-client that requires mbknor-jackson-jsonSchema?

@jtjeferreira
Copy link
Contributor

@jtjeferreira You appear to use the Kinesis connector. Have you run into this issue or do you have any thoughts? Is it possible that we don't use the code in software.amazon.kinesis:amazon-kinesis-client that requires mbknor-jackson-jsonSchema?

I never noticed the use of a _2.12 dependency because in my projects I exclude the software.amazon.glue:schema-registry-serde...

I found this draft PR awslabs/aws-glue-schema-registry#315 and I think we should not be doing anything and let AWS solve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants