-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OperatorInfo should be stored inside Operator to avoid calling metadata #4845
Comments
If my understanding is right, it just wrap And if it is better to use |
Hi, @Lzzzzzt. Thanks for joining the discussion and starting #4883. After some consideration, I think it would be better to modify With this change, |
Ok, got it |
It seems need to change a lot, if modify |
Yes. If we do need API breaking changes, I prefer change |
if modify Access::info() to return Arc, a lot of struct will need a extra field to store the info, is that right? opendal/core/src/services/fs/backend.rs Lines 184 to 210 in 740928e
|
We can start by simply adding an |
some layers need a mutable opendal/core/src/layers/blocking.rs Lines 168 to 185 in 740928e
|
Those layers can build a new |
ok |
I change the signature of |
OperatorInfo will never be changed after
Operator
been built, we can store it inside anArc
inside Operator to avoid extra cost.The text was updated successfully, but these errors were encountered: