net/tcp/udp: Modify calls of net_iob*alloc calls to be unthrottled for sends,

throttle for receives.

The Kconfig option CONFIG_IOB_THROTTLE is used to limit the amount allocated
by TCP (and UDP) receives as to not starve sends. This distinction is made
via a 'throttle' argument passed to the iob_*alloc functions, which are wrapped
by net_iob*alloc. Previously the udp/tcp_wrbuffer_write functions incorrectly
allocate with throttle=true, effectively making the IOB_THROTTLE option useless.

This patch modifies the calls in udp/tcp_wrbuffer_write to allocate unthrottled,
and fixes an unthrottled allocation in the TCP receive path.

There were also several locations in the receive path that incorrectly
allocated unthrottled.

Signed-off-by: Menno Vanfrachem <[email protected]>

Modify receives to allocate throttled

Author: mennovf

Documentation/components/net/netdriver.rst

@@ -229,7 +229,8 @@ Here is a guide to do so:
          */
 
         len = receive_data_into(devbuf);
-        netpkt_copyin(dev, pkt, devbuf + sizeof(struct <chip>_rxhead_s), len, 0);
+        netpkt_copyin(dev, pkt, devbuf + sizeof(struct <chip>_rxhead_s), len, 0,
+                      NETPKT_RX);
   #endif
       }
 

arch/risc-v/src/common/espressif/esp_wlan_netdev.c

@@ -1018,7 +1018,7 @@ static int wlan_rx_done(struct esp_wlan_priv_s *priv,
       goto out;
     }
 
-  ret = netpkt_copyin(&priv->dev, pkt, buffer, len, 0);
+  ret = netpkt_copyin(&priv->dev, pkt, buffer, len, 0, NETPKT_RX);
   if (ret < 0)
     {
       wlerr("ERROR: Failed to copy packet\n");

arch/risc-v/src/mpfs/mpfs_can.c

@@ -678,7 +678,8 @@ static netpkt_t *mpfs_receive(struct netdev_lowerhalf_s *dev)
           if (pkt != NULL)
             {
               netpkt_copyin(dev, pkt, (uint8_t *)&cf,
-                           sizeof(struct can_frame), 0);
+                           sizeof(struct can_frame), 0
+                           NETPKT_RX);
             }
 
           ninfo("Received CAN message (ID: 0x%X, DLC: %d) "

arch/sim/src/sim/sim_netdriver.c

@@ -181,7 +181,7 @@ static netpkt_t *netdriver_recv(struct netdev_lowerhalf_s *dev)
 #ifdef SIM_NETDEV_RECV_OFFLOAD
       netpkt_setdatalen(dev, pkt, len);
 #else
-      netpkt_copyin(dev, pkt, DEVBUF(dev), len, 0);
+      netpkt_copyin(dev, pkt, DEVBUF(dev), len, 0, NETPKT_RX);
 #endif
     }
 

arch/xtensa/src/common/espressif/esp_openeth.c

@@ -286,7 +286,7 @@ static netpkt_t *openeth_receive(struct netdev_lowerhalf_s *dev)
           goto err;
         }
 
-      netpkt_copyin(dev, pkt, desc_val.rxpnt, desc_val.len, 0);
+      netpkt_copyin(dev, pkt, desc_val.rxpnt, desc_val.len, 0, NETPKT_RX);
 
       /* Free up the descriptor */
 

arch/xtensa/src/common/espressif/esp_wlan_netdev.c

@@ -1018,7 +1018,7 @@ static int wlan_rx_done(struct esp_wlan_priv_s *priv,
       goto out;
     }
 
-  ret = netpkt_copyin(&priv->dev, pkt, buffer, len, 0);
+  ret = netpkt_copyin(&priv->dev, pkt, buffer, len, 0, NETPKT_RX);
   if (ret < 0)
     {
       wlerr("ERROR: Failed to copy packet\n");

drivers/net/netdev_upperhalf.c

@@ -1395,7 +1395,7 @@ FAR netpkt_t *netpkt_alloc(FAR struct netdev_lowerhalf_s *dev,
       return NULL;
     }
 
-  pkt = iob_tryalloc(false);
+  pkt = iob_tryalloc(type == NETPKT_RX);
   if (pkt == NULL)
     {
       atomic_fetch_add(&dev->quota[type], 1);
@@ -1446,10 +1446,12 @@ void netpkt_free(FAR struct netdev_lowerhalf_s *dev, FAR netpkt_t *pkt,
  ****************************************************************************/
 
 int netpkt_copyin(FAR struct netdev_lowerhalf_s *dev, FAR netpkt_t *pkt,
-                  FAR const uint8_t *src, unsigned int len, int offset)
+                  FAR const uint8_t *src, unsigned int len, int offset,
+                  enum netpkt_type_e type)
 {
   return iob_trycopyin(pkt, src, len,
-                       offset - NET_LL_HDRLEN(&dev->netdev), false);
+                       offset - NET_LL_HDRLEN(&dev->netdev),
+                       type == NETPKT_RX);
 }
 
 /****************************************************************************

drivers/net/oa_tc6/oa_tc6.c

@@ -867,7 +867,8 @@ static void oa_tc6_handle_rx_chunk(FAR struct oa_tc6_driver_s *priv,
         }
 
       netpkt_copyin(&priv->dev, priv->rx_pkt, rxbuf,
-                    rxlen, priv->rx_pkt_idx);
+                    rxlen, priv->rx_pkt_idx,
+                    NETPKT_RX);
       priv->rx_pkt_idx = newlen;
 
       if (oa_tc6_end_valid(footer))

drivers/net/tun.c

@@ -998,7 +998,7 @@ static ssize_t tun_write(FAR struct file *filep, FAR const char *buffer,
         {
           net_lock();
           netdev_iob_release(&priv->dev);
-          ret = netdev_iob_prepare(&priv->dev, false, 0);
+          ret = netdev_iob_prepare(&priv->dev, true, 0);
           priv->dev.d_buf = NULL;
           if (ret < 0)
             {

drivers/usbdev/cdcncm.c

@@ -977,7 +977,7 @@ static int cdcncm_packet_handler(FAR struct cdcncm_driver_s *self,
       return ret;
     }
 
-  ret = netpkt_copyin(&self->dev, pkt, dgram, dglen, 0);
+  ret = netpkt_copyin(&self->dev, pkt, dgram, dglen, 0, NETPKT_RX);
   if (ret < 0)
     {
       netpkt_free(&self->dev, pkt, NETPKT_RX);