-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is no module-info source in log4j-core-3.0.0-beta3-sources.jar #3255
Comments
Hi @PavelTurk, While ideally we could have a text representation of I don't believe this is a big problem, since the information in |
The ASF has no requirement that generated source files appear in the source release. The ASF release policy states "Every ASF release must contain a source package, which must be sufficient for a user to build and test the release provided they have access to the appropriate platform and tools.". In general, a source release package should contain exactly what is in source control under the tag for that release. Doing anything else would lead to problems. |
I think we are talking about the Maven Currently it contains some generated code/resources:
Even if we do decompile
|
I am afraid it is not a good solution. Because it is a standard way to get sources from |
My IDE (IDEA) automatically decompiles the file and the same functionality is available in Eclipse. I am not saying this is not an issue, but it is a minor one. Feel free to open a PR that fixes this problem. As I mentioned above, this will probably require changes to BND Maven Plugin and maybe Maven Source Plugin, so it seems to be a long run. |
The problem is not decompilation (NB also has a Java decompiler plugin); the problem lies in deviating from the standard. But these are just thoughts out loud... |
@PavelTurk What "standard"? |
Description
As I found out
module-info
is generated automatically in 3.0.0-beta3. At the same time its source (module-info.java
) must be present in*-3.0.0-beta3-sources.jar
files. For example, there is nomodule-info.java
inlog4j-core-3.0.0-beta3-sources.jar
see [1], but there is amodule-info.class
inlog4j-core-3.0.0-beta3.jar
see [2].The absence of module-info.java makes it difficult for library user to get important information about module, for example, its dependencies, provided and used services etc.
[1] https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j-core/3.0.0-beta3/log4j-core-3.0.0-beta3-sources.jar
[2] https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j-core/3.0.0-beta3/log4j-core-3.0.0-beta3.jar
The text was updated successfully, but these errors were encountered: