Skip to content

Commit

Permalink
Simplify test case mods
Browse files Browse the repository at this point in the history
  • Loading branch information
stephen-webb committed Jul 15, 2024
1 parent 745a267 commit a037e4c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
14 changes: 7 additions & 7 deletions src/test/cpp/customlogger/xlogger.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,14 @@ XFactory::XFactory()
{
}

LoggerPtr XFactory::makeNewLoggerInstance(const LogString& name) const
#if LOG4CXX_ABI_VERSION <= 15
LoggerPtr XFactory::makeNewLoggerInstance(helpers::Pool&, const LogString& name) const
{
return LoggerPtr(new XLogger(name));
}

#if LOG4CXX_ABI_VERSION <= 15
LoggerPtr XFactory::makeNewLoggerInstance(
helpers::Pool& pool,
const LogString& name) const
{ return makeNewLoggerInstance(name); }
#endif

LoggerPtr XFactory::makeNewLoggerInstance(const LogString& name) const
{
return LoggerPtr(new XLogger(name));
}
10 changes: 4 additions & 6 deletions src/test/cpp/customlogger/xlogger.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,14 @@ class XFactory :

XFactory();

#if LOG4CXX_ABI_VERSION <= 15
LoggerPtr makeNewLoggerInstance(const LogString& name) const;
#else
LoggerPtr makeNewLoggerInstance(const LogString& name) const override;
#endif

#if LOG4CXX_ABI_VERSION <= 15
LoggerPtr makeNewLoggerInstance(
helpers::Pool& pool,
const LogString& name) const override;

LoggerPtr makeNewLoggerInstance(const LogString& name) const;
#else
LoggerPtr makeNewLoggerInstance(const LogString& name) const override;
#endif
};

Expand Down

0 comments on commit a037e4c

Please sign in to comment.