Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0.x] kie-issues#1397: Adjust release pipelines for the Apache 10 release #3111

Merged
merged 2 commits into from
Jul 26, 2024
Merged

[10.0.x] kie-issues#1397: Adjust release pipelines for the Apache 10 release #3111

merged 2 commits into from
Jul 26, 2024

Conversation

rodrigonull
Copy link
Contributor

@kie-ci3
Copy link

kie-ci3 commented Jul 23, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-optaplanner/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-optaplanner -u #3111 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/optaplanner/job/main/job/pullrequest_jobs/job/optaplanner-pr/job/PR-3111/1/display/redirect

Test results:

  • PASSED: 4902
  • FAILED: 13

Those are the test failures:

org.acme.schooltimetabling.TimeTableMessagingHandlerTest.solvingThrowsException java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
PR check / Build projects / org.acme.schooltimetabling.solver.TimeTableBenchmarkTest.benchmark jakarta/xml/bind/JAXBException
org.acme.kotlin.schooltimetabling.rest.TimeTableResourceTest.solveDemoDataUntilFeasible java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.demoapp.rest.DemoDataResourceTest.createTimeTable java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.schooltimetabling.messaging.MessageHandlerTest.incorrectSolutionClass_respondsWithError java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.callcenter.solver.CallCenterConstraintProviderTest.noRequiredSkillMissing java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.employeescheduling.rest.EmployeeScheduleResourceTest.solveDemoDataUntilFeasible java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.facilitylocation.solver.FacilityLocationConstraintProviderTest.no_penalty_when_consumer_not_assigned java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.maintenancescheduling.rest.MaintenanceScheduleResourceTest.solveDemoDataUntilFeasible java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.orderpicking.solver.OrderPickingConstraintProviderTest.minimizeDistanceFromLastTrolleyStepToPathOrigin java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.schooltimetabling.rest.LessonResourceTest.getAll java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.vaccinationscheduler.solver.VaccinationScheduleConstraintProviderTest.requiredVaccinationCenter java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.vehiclerouting.rest.SolverResourceTest.solve java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder

tkobayas
tkobayas approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@tkobayas tkobayas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR errors seem to be the same as Paolo reported in dev ML "[REVIEW] [NOT OK] Current status for the optaplanner 10.x jobs". Probably @lucamolteni can help?

@lucamolteni
Copy link
Contributor

The PR errors seem to be the same as Paolo reported in dev ML "[REVIEW] [NOT OK] Current status for the optaplanner 10.x jobs". Probably @lucamolteni can help?

Yes these tests are taking from optaplanner-quickstarts and those should be taken from the

The PR errors seem to be the same as Paolo reported in dev ML "[REVIEW] [NOT OK] Current status for the optaplanner 10.x jobs". Probably @lucamolteni can help?

I've answered in the apache ML but I'll copy my answer here as well

Was the 10.0.x branch taken from 8 because of this mapping that wasn’t never updated? (I’ve created a PR for it)

https://github.com/apache/incubator-kie-optaplanner/pull/3112/files

Reading the log from this failing PR (#3111)

[2024-07-23T19:21:26.364Z] # Checkout summary
[2024-07-23T19:21:26.364Z] [INFO] [apache/incubator-kie-optaplanner]
[2024-07-23T19:21:26.364Z] [INFO] Project taken from apache/incubator-kie-optaplanner:10.0.x (Branch HEAD 26504a8)
[2024-07-23T19:21:26.364Z] [INFO] Merged rodrigonull/incubator-kie-optaplanner:adjust-release-jobs into branch 10.0.x
[2024-07-23T19:21:26.364Z] [INFO] [apache/incubator-kie-optaplanner-quickstarts]
[2024-07-23T19:21:26.365Z] [INFO] Project taken from apache/incubator-kie-optaplanner-quickstarts:10.0.x (Branch HEAD b690beadc53493fb132e8a93d0b9d269f5452fed)

I see that build-chain is taking the 10.0.x branch from optaplanner-quickstart, but as Toshiya already noticed, the 10.0.x branch was wrongly created (see https://github.com/apache/incubator-kie-optaplanner-quickstarts/commits/10.0.x the last commit before the bump is 0085584a74976b66d8f43c1155012773c52e3fe1 instead of 752f8be515cbd02d1fc130dda75adb6e99b0dca7

I’m not sure if this email alone can help, feel free to ping me on Zulip so that we can fix this

jstastny-cz
jstastny-cz approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kie-ci3
Copy link

kie-ci3 commented Jul 25, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-optaplanner/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-optaplanner -u #3111 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/optaplanner/job/main/job/pullrequest_jobs/job/optaplanner-pr/job/PR-3111/2/display/redirect

Test results:

  • PASSED: 4902
  • FAILED: 13

Those are the test failures:

org.acme.schooltimetabling.TimeTableMessagingHandlerTest.solvingThrowsException java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
PR check / Build projects / org.acme.schooltimetabling.solver.TimeTableBenchmarkTest.benchmark jakarta/xml/bind/JAXBException
org.acme.kotlin.schooltimetabling.rest.TimeTableResourceTest.solveDemoDataUntilFeasible java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.demoapp.rest.DemoDataResourceTest.createTimeTable java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.schooltimetabling.messaging.MessageHandlerTest.incorrectSolutionClass_respondsWithError java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.callcenter.solver.CallCenterConstraintProviderTest.noRequiredSkillMissing java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.employeescheduling.rest.EmployeeScheduleResourceTest.solveDemoDataUntilFeasible java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.facilitylocation.solver.FacilityLocationConstraintProviderTest.no_penalty_when_consumer_not_assigned java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.maintenancescheduling.rest.MaintenanceScheduleResourceTest.solveDemoDataUntilFeasible java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.orderpicking.solver.OrderPickingConstraintProviderTest.minimizeDistanceFromLastTrolleyStepToPathOrigin java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.schooltimetabling.rest.LessonResourceTest.getAll java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.vaccinationscheduler.solver.VaccinationScheduleConstraintProviderTest.requiredVaccinationCenter java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder
org.acme.vehiclerouting.rest.SolverResourceTest.solve java.lang.NoClassDefFoundError: io/quarkus/devui/spi/page/PageBuilder

@lucamolteni
Copy link
Contributor

see apache/incubator-kie-optaplanner-quickstarts#632 (comment)

TBF I've never seen the Quickstart repo being built without .withProperty('maven.test.failure.ignore', true) so perhaps this is expected?

@rodrigonull rodrigonull merged commit 79c52dc into apache:10.0.x Jul 26, 2024
2 checks passed
@rodrigonull rodrigonull deleted the adjust-release-jobs branch August 27, 2024 18:20
rodrigonull added a commit to rodrigonull/incubator-kie-optaplanner that referenced this pull request Sep 17, 2024
@rodrigonull
[10.0.x] kie-issues#1397: Adjust release pipelines for the Apache 10 …
9a378d8 
…release (apache#3111)

* Adjust release pipelines for the Apache 10 release

* Adjust release pipelines for the Apache 10 release
rodrigonull added a commit that referenced this pull request Oct 7, 2024
@rodrigonull
NO-ISSUE: Jenkins jobs updates and fixes for Apache 10 release (#3125)
a4ca387 
* [10.0.x] kie-issues#1397: Adjust release pipelines for the Apache 10 release (#3111)

* Adjust release pipelines for the Apache 10 release

* Adjust release pipelines for the Apache 10 release

* [10.0.x] NO-ISSUE: Fix release configuration keys (#3116)

* Fix release configuration keys

* Rename release.groovy file to avoid conflicts with the RELEASE env var

* Switch to GPG File Jenkins secret

* [10.0.x] NO-ISSUE: Fix release job display name (#3117)

Fix release job display name

* [10.0.x] NO-ISSUE: Setup nexus credentials to build parent modules (#3119)

Setup nexus credentials to build parent modules

* [10.0.x] NO-ISSUE: Use release settings to update version and parent versions (#3120)

Use release settings to update version and parent version

* [10.0.x] NO-ISSUE: Disable generate-code-tests goal and fixes for the release job (#3121)

Disable generate-code-tests goal and fixes for the release job

* Release job updates and fixes for Apache 10 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstastny-cz jstastny-cz jstastny-cz approved these changes

@tkobayas tkobayas tkobayas approved these changes

@wmedvede wmedvede Awaiting requested review from wmedvede

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rodrigonull @kie-ci3 @lucamolteni @tkobayas @jstastny-cz