kie-issues#1213: configure for dockerhub registry #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2024
ricardozanini
approved these changes
May 15, 2024
rodrigonull
requested changes
Jun 25, 2024
Co-authored-by: Rodrigo Antunes <[email protected]>
|
@jstastny-cz I'm not sure why the dsl test is failing. Can you verify? |
ricardozanini
approved these changes
Jun 25, 2024
| String temporaryImageName = imageUtils.getImageFullName(getOperatorImageNamespace(), getOperatorImageName(), | ||
| getOperatorImageTemporaryTag()) | ||
| // https://docs.docker.com/docker-hub/api/latest/#tag/repositories | ||
| error "Dockerhub API does not allow deleting tags via API. The OptaPlanner Operator temporary image tag (${temporaryImageName}) should be removed manually." |
There was a problem hiding this comment.
@rodrigonull maybe it's this line the CI is complaining about?
org.spockframework.runtime.UnallowedExceptionThrownError at JobScriptsSpec.groovy:97
There was a problem hiding this comment.
I guess we can use throw? https://www.jenkins.io/doc/book/pipeline/syntax/#flow-control
I'm not sure, I'm not a Jenkins SME just brainstorming. :)
|
Those tests don't work well when my fork name is different than the actual repo :/ |
|
Tests passed when running locally with correct overrides. The test scripts would need much time investment, I might rather rename my forks :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Depends on
docker.io/apache/incubator-kie-kogito-ci-build:main-latestbeing released first (after #1197 is merged and pipeline execution succeeds).Part of PR group: