[MINOR] Fix ZipFile resource leak in ResourceUtil#11617
Merged
philo-he merged 1 commit intoapache:mainfrom Feb 19, 2026
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
acvictor
force-pushed
the
acvictor/fixZipFileResourceLeak
branch
from
0325ad2 to
984d572
Compare
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
@philo-he can you please help review this PR? Thanks in advance! |
zhztheplayer
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR refactors
ResourceUtil.getResourcesFromJarFile()to use try-with-resources forZipFile, replacing the manual open/close pattern. The existing code opens a file in one try block and closes it in a separate try block at the end of the method. If any unchecked exception is thrown while iterating over the zip entries,ZipFile.close()is never called, leaking a file descriptor.How was this patch tested?
Existing unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.