From fe02feefb8ea11f2b00c3c98713b5c034d1cd47a Mon Sep 17 00:00:00 2001 From: Hongze Zhang Date: Tue, 7 Jan 2025 17:03:48 +0800 Subject: [PATCH] [VL] Remove an out-of-date warning message (#8447) --- cpp/velox/compute/VeloxBackend.cc | 4 ---- .../org/apache/gluten/integration/command/Parameterized.java | 2 +- .../java/org/apache/gluten/integration/command/Queries.java | 2 +- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/cpp/velox/compute/VeloxBackend.cc b/cpp/velox/compute/VeloxBackend.cc index 3beda675398b..328cd724858a 100644 --- a/cpp/velox/compute/VeloxBackend.cc +++ b/cpp/velox/compute/VeloxBackend.cc @@ -280,10 +280,6 @@ void VeloxBackend::initConnector() { ioThreads >= 0, kVeloxIOThreads + " was set to negative number " + std::to_string(ioThreads) + ", this should not happen."); if (ioThreads > 0) { - LOG(WARNING) - << "Velox background IO threads is enabled. Which is highly unrecommended as of now, since it may cause" - << " some unexpected issues like query crash or hanging. Please turn it off if you are unsure about" - << " this option."; ioExecutor_ = std::make_unique(ioThreads); } velox::connector::registerConnector(std::make_shared( diff --git a/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Parameterized.java b/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Parameterized.java index 9ce910e0bbe3..0b96ae3c7108 100644 --- a/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Parameterized.java +++ b/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Parameterized.java @@ -46,7 +46,7 @@ public class Parameterized implements Callable { @CommandLine.Option(names = {"--warmup-iterations"}, description = "Dry-run iterations before actually run the test", defaultValue = "0") private int warmupIterations; - @CommandLine.Option(names = {"-m", "--metric"}, description = "Specify a series of metrics to collect during execution") + @CommandLine.Option(names = {"-m", "--metric"}, description = "Specify a series of executor metrics to collect during execution") private String[] metrics = new String[0]; @CommandLine.Option(names = {"-d", "--dim"}, description = "Set a series of dimensions consisting of possible config options, example: -d=offheap:1g,spark.memory.offHeap.enabled=true,spark.memory.offHeap.size=1g") diff --git a/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Queries.java b/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Queries.java index b4ac90a6beb1..456998cb2f07 100644 --- a/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Queries.java +++ b/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Queries.java @@ -44,7 +44,7 @@ public class Queries implements Callable { @CommandLine.Option(names = {"--random-kill-tasks"}, description = "Every single task will get killed and retried after running for some time", defaultValue = "false") private boolean randomKillTasks; - @CommandLine.Option(names = {"--collect-sql-metrics"}, description = "Collect SQL metrics from run queries and generate a simple report based on them. Available types: execution-time") + @CommandLine.Option(names = {"--sql-metrics"}, description = "Collect SQL metrics from run queries and generate a simple report based on them. Available types: execution-time") private Set collectSqlMetrics = Collections.emptySet(); @Override