[HUDI-8786] Running intellij code cleanup #12524
Open
+592
−670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinothchandar
changed the title
- On top, fixed to make checkstyle happy
vinothchandar
force-pushed
the
idea-cleanups
branch
from
e39adf3 to
e180b9e
Compare
vinothchandar
commented
Dec 19, 2024
...rc/main/java/org/apache/hudi/common/table/read/HoodiePositionBasedFileGroupRecordBuffer.java
Show resolved
Hide resolved
linliu-code
approved these changes
Dec 20, 2024
yihua
requested changes
Dec 20, 2024
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/AsyncClusteringService.java
Outdated
Show resolved
Hide resolved
yihua
reviewed
Dec 20, 2024
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncService.java
Outdated
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/AsyncClusteringService.java
Outdated
Show resolved
Hide resolved
yihua
reviewed
Dec 20, 2024
| @@ -33,9 +33,9 @@ public class WorkloadStat implements Serializable { | |||
|
|
|||
| private long numUpdates = 0L; | |||
|
|
|||
| private HashMap<String, Pair<String, Long>> insertLocationToCount; | |||
| private final HashMap<String, Pair<String, Long>> insertLocationToCount; | |||
There was a problem hiding this comment.
Also, for Java serialization and deserialization to work in Spark, these member variables cannot be final.
There was a problem hiding this comment.
I think for any class that already has final variables, it is safe to add additional final variables. Otherwise, we need to be careful around the Serializable.
| .setBootstrapFilePath(slice.getBaseFile().map(bf -> bf.getBootstrapBaseFile().map(bbf -> bbf.getPath()).orElse(StringUtils.EMPTY_STRING)).orElse(StringUtils.EMPTY_STRING)) | ||
| .build()).collect(Collectors.toList()); | ||
| return slices.stream().map(slice -> { | ||
| new HoodieSliceInfo(); |
There was a problem hiding this comment.
dont follow. checkstyle was failing due to bad indentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
finalmodified added as needed.toString()All the changes are auto generated.
Impact
None
Risk level (write none, low medium or high below)
low
Documentation Update
none
Contributor's checklist