[HUDI-7438] Fix Azure CI report check with new issue comments

yihua · yihua · commit c30a56430b52 · 2024-02-24T15:42:33.000-08:00
diff --git a/.github/workflows/azure_ci.js b/.github/workflows/azure_ci.js
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+async function checkAzureCiStatus({ github, context, prNumber, latestCommitHash }) {
+  console.log(`- Checking Azure CI status of PR: ${prNumber} ${latestCommitHash}`);
+  const botUsername = 'hudi-bot';
+
+  const comments = await github.rest.issues.listComments({
+    owner: context.repo.owner,
+    repo: context.repo.repo,
+    issue_number: prNumber,
+  });
+
+  // Find the latest comment from hudi-bot containing the Azure CI report
+  const botComments = comments.data.filter(comment => comment.user.login === botUsername);
+  const lastComment = botComments.pop();
+
+  let status = 'pending';
+  let message = 'In progress';
+  let azureRunLink = '';
+
+  if (lastComment) {
+    const reportPrefix = `${latestCommitHash} Azure: `
+    const successReportString = `${reportPrefix}[SUCCESS]`
+    const failureReportString = `${reportPrefix}[FAILURE]`
+
+    if (lastComment.body.includes(reportPrefix)) {
+      if (lastComment.body.includes(successReportString)) {
+        message = 'Successful on the latest commit';
+        status = 'success';
+      } else if (lastComment.body.includes(failureReportString)) {
+        message = 'Failed on the latest commit';
+        status = 'failure';
+      }
+    }
+
+    const linkRegex = /\[[a-zA-Z]+\]\((https?:\/\/[^\s]+)\)/;
+    const parts = lastComment.body.split(reportPrefix);
+    const secondPart = parts.length > 1 ? parts[1] : '';
+    const match = secondPart.match(linkRegex);
+
+    if (match) {
+      azureRunLink = match[1];
+    }
+  }
+
+  console.log(`Status: ${status}`);
+  console.log(`Azure Run Link: ${azureRunLink}`);
+  console.log(`${message}`);
+
+  console.log(`- Create commit status of PR based on Azure CI status: ${prNumber} ${latestCommitHash}`);
+  // Create or update the commit status for Azure CI
+  await github.rest.repos.createCommitStatus({
+    owner: context.repo.owner,
+    repo: context.repo.repo,
+    sha: latestCommitHash,
+    state: status,
+    target_url: azureRunLink,
+    description: message,
+    context: 'Azure CI'
+  });
+
+  return { status, message, azureRunLink };
+}
+
+module.exports = checkAzureCiStatus;
diff --git a/.github/workflows/azure_ci_check.yml b/.github/workflows/azure_ci_check.yml
@@ -18,17 +18,22 @@
 name: Azure CI
 
 on:
+  pull_request:
+    types: [ opened, edited, reopened, synchronize ]
   issue_comment:
     types: [ created, edited, deleted ]
 
 permissions:
+  checks: write
   statuses: write
   pull-requests: read
   issues: read
 
 jobs:
   check-azure-ci-report:
-    if: "!contains(github.event.pull_request.body, 'HOTFIX: SKIP AZURE CI')"
+    if: true #|
+    #github.event.issue.pull_request != null &&
+    #!contains(github.event.pull_request.body, 'HOTFIX: SKIP AZURE CI')
     runs-on: ubuntu-latest
     steps:
       - name: Get last commit hash
@@ -37,13 +42,20 @@ jobs:
         with:
           github-token: ${{secrets.GITHUB_TOKEN}}
           script: |
-            const pr = context.payload.pull_request;
-            const lastCommitHash = pr.head.sha;
-            console.log(`Last commit hash: ${lastCommitHash}`);
+            const issueNumber = 10740; // github.event.issue.number;
+            const { data: pullRequest } = await github.rest.pulls.get({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              pull_number: issueNumber
+            });
+            
+            const commitHash = pullRequest.head.sha;
+            console.log(`Latest commit hash: ${commitHash}`);
             // Set the output variable to be used in subsequent step
-            core.setOutput("last_commit_hash", lastCommitHash);
+            core.setOutput("last_commit_hash", commitHash);
 
       - name: Check Azure CI report in PR comment
+        id: check_report_in_pr_comment
         uses: actions/github-script@v7
         with:
           github-token: ${{secrets.GITHUB_TOKEN}}
@@ -62,32 +74,69 @@ jobs:
             const botComments = comments.data.filter(comment => comment.user.login === botUsername);
             const lastComment = botComments.pop();
             
+            let message = '';
+            let result = false;
+            
             if (lastComment) {
               const reportPrefix = '${lastCommitHash} Azure: '
               const successReportString = '${reportPrefix}[SUCCESS]'
               const failureReportString = '${reportPrefix}[FAILURE]'
               if (lastComment.body.includes(reportPrefix)) {
                 if (lastComment.body.includes(successReportString)) {
-                  console.log(`Azure CI succeeded on the latest commit of the PR.`);
-                  return true;
+                  message = 'Azure CI succeeded on the latest commit of the PR.';
+                  result = true;
                 } else if (lastComment.body.includes(failureReportString)) {
-                  console.log(`Azure CI failed on the latest commit of the PR.`);
-                  core.setFailed("Azure CI failed on the latest commit of the PR.");
-                  return false;
+                  message = 'Azure CI failed on the latest commit of the PR';
+                  result = false;
                 } else {
-                  console.log(`Azure CI is in progress on the latest commit of the PR.`);
-                  core.setFailed("Azure CI is in progress on the latest commit of the PR.");
-                  return false;
+                  message = 'Azure CI is in progress on the latest commit of the PR.';
+                  result = false;
                 }
               } else {
-                console.log(`No Azure CI report on the latest commit of the PR.`);
-                core.setFailed("No Azure CI report on the latest commit of the PR.");
-                return false;
+                message = 'No Azure CI report on the latest commit of the PR.';
+                result = false;
               }
             } else {
-              console.log(`Azure CI report does not seem to be ready yet.`);
-              core.setFailed("Azure CI report does not seem to be ready yet.");
-              return false;
+              message = 'Azure CI report does not seem to be ready yet.';
+              result = false;
             }
+            console.log(`${message}`);
+            core.setOutput("check_result_message", message);
+            core.setOutput("is_check_successful", result);
         env:
           GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
+
+      - name: Attach Azure CI report check to the PR
+        uses: actions/github-script@v5
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            let conclusionString = 'failure';
+            if (${{ steps.check_report_in_pr_comment.outputs.is_check_successful }}) {
+              conclusionString = 'success';
+            }
+            console.log(`Check status: ${conclusionString}`);
+            await github.rest.checks.create({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              name: 'Azure CI Report Check',
+              head_sha: '${{ steps.last_commit.outputs.last_commit_hash }}',
+              status: 'completed',
+              conclusion: '${conclusionString}',
+              completed_at: new Date(),
+              output: {
+                title: 'Azure CI Report Check',
+                summary: '${{ steps.check_report_in_pr_comment.outputs.check_result_message }}',
+              }
+            });
+
+      - name: Remove Azure CI Blocker check
+        run: |
+          curl -X GET \
+            -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
+            -H "Accept: application/vnd.github.v3+json" \
+            https://api.github.com/repos/${{ github.repository }}/commits/${{ steps.last_commit.outputs.last_commit_hash }}/check-runs | jq '.check_runs[] | select(.name | contains("create-azure-ci-report-check")) | .id' | xargs -I {} curl -X PATCH \
+            -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
+            -H "Accept: application/vnd.github.v3+json" \
+            -d '{"status": "neutral"}' \
+            https://api.github.com/repos/${{ github.repository }}/check-runs/{}
diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml
@@ -1,24 +1,54 @@
 name: Label PR
 
-on: [ pull_request ]
+on:
+  pull_request:
+    types: [ opened, edited, reopened, synchronize ]
+
+permissions:
+  issues: write
+  pull-requests: write
 
 jobs:
   labeler:
     runs-on: ubuntu-latest
-    name: Label the PR size
     steps:
-      - uses: codelytv/pr-size-labeler@v1
+      - name: Label PR size
+        uses: actions/github-script@v7
         with:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          xs_label: 'size-xs'
-          xs_max_size: '10'
-          s_label: 'size-s'
-          s_max_size: '100'
-          m_label: 'size-m'
-          m_max_size: '500'
-          l_label: 'size-l'
-          l_max_size: '1000'
-          xl_label: 'size-xl'
-          fail_if_xl: 'false'
-          github_api_url: 'api.github.com'
-          files_to_ignore: ''
+          github-token: ${{secrets.GITHUB_TOKEN}}
+          script: |
+            const prNumber = context.payload.pull_request.number;
+            const { data: prData } = await github.rest.pulls.get({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              pull_number: prNumber,
+            });
+            
+            const additions = prData.additions;
+            const deletions = prData.deletions;
+            const totalChanges = additions + deletions;
+            
+            let label = "";
+            
+            if (totalChanges < 10) {
+              label = "size:XS";
+            } else if (totalChanges < 100) {
+              label = "size:S";
+            } else if (totalChanges < 300) {
+              label = "size:M";
+            } else if (totalChanges < 1000) {
+              label = "size:L";
+            } else {
+              label = "size:XL";
+            }
+            
+            // Apply the label
+            await github.rest.issues.addLabels({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: prNumber,
+              labels: [label],
+            });
+            
+            console.log(`Total lines of changes: ${totalChanges}`);
+            console.log(`Label: ${label}`);
diff --git a/.github/workflows/scheduled_workflow.yml b/.github/workflows/scheduled_workflow.yml
