HIVE-29465:Prevent excessive query results cache usage at runtime#6376
Open
ramitg254 wants to merge 3 commits intoapache:masterfrom
Open
HIVE-29465:Prevent excessive query results cache usage at runtime#6376ramitg254 wants to merge 3 commits intoapache:masterfrom
ramitg254 wants to merge 3 commits intoapache:masterfrom
Conversation
ramitg254
changed the title
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
ramitg254
changed the title
ramitg254
changed the title
ramitg254
changed the title
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
abstractdog
reviewed
Apr 14, 2026
| cacheFs.mkdirs(resultDir); | ||
|
|
||
| Set<FileStatus> cacheFilesToFetch = new HashSet<>(); | ||
| rwLock.writeLock().lock(); |
Contributor
There was a problem hiding this comment.
I can see that in other places in this class, this is handled via a separate variable:
Lock writeLock = rwLock.writeLock();
try{
writeLock.lock();
}
but that usage pattern is not consistent: feel free to pick one, and unify all the lock usages
Contributor
Author
There was a problem hiding this comment.
done moved to withWriteLock() method
abstractdog
reviewed
Apr 14, 2026
| return false; | ||
| } | ||
|
|
||
| if (isSafeCacheWriteEnabled) { |
Contributor
There was a problem hiding this comment.
maybe refactor this whole block to a separate method
Contributor
Author
There was a problem hiding this comment.
done moved to rewriteFetchWorkForSafeCacheWrite method
abstractdog
requested changes
Apr 14, 2026
abstractdog
reviewed
Apr 14, 2026
| "If the query results cache is enabled. This will keep results of previously executed queries " + | ||
| "to be reused if the same query is executed again."), | ||
|
|
||
| HIVE_QUERY_RESULTS_SAFE_CACHE_WRITE_ENABLED("hive.query.results.safe.cache.write.enabled", false, |
Contributor
There was a problem hiding this comment.
for correct alphabetical order this should rather be hive.query.results.cache.safe.write.enabled
Contributor
Author
There was a problem hiding this comment.
done corrected order
abstractdog
requested changes
Apr 14, 2026
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
|
asf-ci-hive
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introducing safe cache writing conf which is when enabled writing to cache directory should not happen dirctly and if the entry is valid then only that entry should be copied to cache directory.
Why are the changes needed?
spilling of cache directory was happening when query as cleanup is done in the post execution.
Does this PR introduce any user-facing change?
No
How was this patch tested?
locally and ci test