Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-26332: Test surefire upgrade to 3.1.3-SNAPSHOT for SUREFIRE-1934 #5334

Closed
wants to merge 2 commits into from

Conversation

zabetak
Copy link
Contributor

@zabetak zabetak commented Jul 3, 2024

What changes were proposed in this pull request?

Upgrade surefire plugin to 3.1.3-SNAPSHOT

Why are the changes needed?

Test if failures related to SUREFIRE-1934 are resolved and what else remains to be done for upgrading

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

1. Set `enableOutErrElements` to `false` to exclude system-out/system-err from XML report for succesful tests (retain current behavior).
2. Remove `failIfNoTests` since by default is false.
3. Set `failIfNoSpecifiedTests` to `false` since CI adds bogus `-Dtest` arguments for some stages.
There is STDOUT corruption due to the fact that tests write and use System.setOut. The problem only occurs when we are sending multiline commands (without semicolon) because org.apache.hive.beeline.Commands.handleMultiLineCmd (Line 1113).

See also: https://maven.apache.org/surefire/maven-failsafe-plugin/faq.html#corruptedstream
Copy link

sonarcloud bot commented Jul 31, 2024

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the [email protected] list if the patch is in need of reviews.

@github-actions github-actions bot added the stale label Sep 30, 2024
@github-actions github-actions bot closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants