HIVE-28888: Fix spotbugs issues in hive-storage-api and hive-service-rpc with spotbugs-maven-plugin 4.8.6.6 (#5754)

Author: tanishq-chugh

Jenkinsfile

@@ -251,10 +251,7 @@ git merge origin/target
       }
       stage('Prechecks') {
         def spotbugsProjects = [
-            ":hive-common",
-            ":hive-shims",
             ":hive-storage-api",
-            ":hive-standalone-metastore-common",
             ":hive-service-rpc"
         ]
         sh '''#!/bin/bash
@@ -267,7 +264,7 @@ if [ $n != 0 ]; then
   exit 1
 fi
 '''
-        buildHive("-Pspotbugs -pl " + spotbugsProjects.join(",") + " -am test-compile com.github.spotbugs:spotbugs-maven-plugin:4.0.0:check")
+        buildHive("-Pspotbugs -pl " + spotbugsProjects.join(",") + " -am test-compile com.github.spotbugs:spotbugs-maven-plugin:4.8.6.6:check")
       }
       stage('Compile') {
         buildHive("install -Dtest=noMatches")

pom.xml

@@ -222,7 +222,7 @@
     <json-path.version>2.9.0</json-path.version>
     <janino.version>3.1.12</janino.version>
     <datasketches.version>1.2.0</datasketches.version>
-    <spotbugs.version>4.0.3</spotbugs.version>
+    <spotbugs.version>4.8.6</spotbugs.version>
     <validation-api.version>1.1.0.Final</validation-api.version>
     <aws-secretsmanager-caching.version>1.0.1</aws-secretsmanager-caching.version>
     <aws-java-sdk.version>1.12.720</aws-java-sdk.version>
@@ -2034,11 +2034,11 @@
       <id>spotbugs</id>
       <build>
         <plugins>
-          <!-- Execute as: com.github.spotbugs:spotbugs-maven-plugin:4.0.0:spotbugs -->
+          <!-- Execute as: com.github.spotbugs:spotbugs-maven-plugin:4.8.6.6:spotbugs -->
           <plugin>
             <groupId>com.github.spotbugs</groupId>
             <artifactId>spotbugs-maven-plugin</artifactId>
-            <version>4.0.0</version>
+            <version>4.8.6.6</version>
             <dependencies>
               <!-- Specify the version of spotbugs -->
               <dependency>
@@ -2061,7 +2061,7 @@
           <plugin>
             <groupId>com.github.spotbugs</groupId>
             <artifactId>spotbugs-maven-plugin</artifactId>
-            <version>4.0.0</version>
+            <version>4.8.6.6</version>
             <configuration>
               <fork>true</fork>
               <maxHeap>2048</maxHeap>

ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/formatter/TextDescTableFormatter.java

@@ -292,7 +292,7 @@ private static MaterializationSnapshotFormatter createMaterializationSnapshotFor
         return String.format("SnapshotContext{snapshotId=%d}", snapshotContext.getSnapshotId());
       };
     } else if (snapshot != null && snapshot.getValidTxnList() != null) {
-      ValidTxnWriteIdList validReaderWriteIdList = new ValidTxnWriteIdList(snapshot.getValidTxnList());
+      ValidTxnWriteIdList validReaderWriteIdList = ValidTxnWriteIdList.fromValue(snapshot.getValidTxnList());
       return qualifiedTableName -> {
         ValidWriteIdList writeIdList = validReaderWriteIdList.getTableValidWriteIdList(qualifiedTableName);
         return writeIdList != null ? writeIdList.toString().replace(qualifiedTableName, "") : "Unknown";

ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java

@@ -486,7 +486,7 @@ private ValidWriteIdList extractValidWriteIdList() {
     if (currDesc.getTableName() == null || !org.apache.commons.lang3.StringUtils.isBlank(currDesc.getTableName())) {
       String txnString = job.get(ValidWriteIdList.VALID_WRITEIDS_KEY);
       LOG.debug("FetchOperator get writeIdStr: " + txnString);
-      return txnString == null ? new ValidReaderWriteIdList() : new ValidReaderWriteIdList(txnString);
+      return txnString == null ? new ValidReaderWriteIdList() : ValidReaderWriteIdList.fromValue(txnString);
     }
     return null;  // not fetching from a table directly but from a temp location
   }

ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HybridHashTableContainer.java

@@ -347,7 +347,7 @@ private HybridHashTableContainer(float keyCountAdj, int threshold, float loadFac
 
     if (useBloomFilter) {
       if (newKeyCount <= BLOOM_FILTER_MAX_SIZE) {
-        this.bloom1 = new BloomFilter(newKeyCount);
+        this.bloom1 = BloomFilter.build(newKeyCount);
       } else {
         // To avoid having a huge BloomFilter we need to scale up False Positive Probability
         double fpp = calcFPP(newKeyCount);
@@ -356,7 +356,7 @@ private HybridHashTableContainer(float keyCountAdj, int threshold, float loadFac
           LOG.warn("BloomFilter FPP is greater than 0.5!");
         }
         LOG.info("BloomFilter is using FPP: " + fpp);
-        this.bloom1 = new BloomFilter(newKeyCount, fpp);
+        this.bloom1 = BloomFilter.build(newKeyCount, fpp);
       }
       LOG.info(String.format("Using a bloom-1 filter %d keys of size %d bytes",
         newKeyCount, bloom1.sizeInBytes()));

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorInBloomFilterColDynamicValue.java

@@ -127,7 +127,7 @@ public Object call() throws IOException {
                   BloomKFilter bloomKFilter = BloomKFilter.deserialize(in);
                   return bloomKFilter;
                 } else {
-                  return new BloomKFilter(1);
+                  return BloomKFilter.build(1);
                 }
               } finally {
                 IOUtils.closeStream(in);

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFBloomFilter.java

@@ -67,7 +67,7 @@ private static final class Aggregation implements AggregationBuffer {
     BloomKFilter bf;
 
     public Aggregation(long expectedEntries) {
-      bf = new BloomKFilter(expectedEntries);
+      bf = BloomKFilter.build(expectedEntries);
     }
 
     @Override

ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java

@@ -2287,7 +2287,7 @@ public static boolean isRemovedInsertOnlyTable(Set<String> removedSet) {
    */
   public static ValidTxnWriteIdList getValidTxnWriteIdList(Configuration conf) {
     String txnString = conf.get(ValidTxnWriteIdList.VALID_TABLES_WRITEIDS_KEY);
-    return new ValidTxnWriteIdList(txnString);
+    return ValidTxnWriteIdList.fromValue(txnString);
   }
 
   /**
@@ -2684,7 +2684,7 @@ public static List<Path> getValidDataPaths(Path dataPath, Configuration conf, St
     }
 
     // If ACID/MM tables, then need to find the valid state wrt to given ValidWriteIdList.
-    ValidWriteIdList validWriteIdList = new ValidReaderWriteIdList(validWriteIdStr);
+    ValidWriteIdList validWriteIdList = ValidReaderWriteIdList.fromValue(validWriteIdStr);
     AcidDirectory acidInfo = AcidUtils.getAcidState(dataPath.getFileSystem(conf), dataPath, conf, validWriteIdList, null,
         false);
 

ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java

@@ -786,7 +786,7 @@ static class Context {
           ? AcidOperationalProperties.parseString(txnProperties) : null;
 
       String value = conf.get(ValidWriteIdList.VALID_WRITEIDS_KEY);
-      writeIdList = value == null ? new ValidReaderWriteIdList() : new ValidReaderWriteIdList(value);
+      writeIdList = value == null ? new ValidReaderWriteIdList() : ValidReaderWriteIdList.fromValue(value);
       LOG.info("Context:: " +
           "isAcid: {} " +
           "isVectorMode: {} " +
@@ -2097,7 +2097,7 @@ public RowReader<OrcStruct> getReader(InputSplit inputSplit,
 
     String txnString = conf.get(ValidWriteIdList.VALID_WRITEIDS_KEY);
     ValidWriteIdList validWriteIdList
-            = (txnString == null) ? new ValidReaderWriteIdList() : new ValidReaderWriteIdList(txnString);
+            = (txnString == null) ? new ValidReaderWriteIdList() : ValidReaderWriteIdList.fromValue(txnString);
     if (LOG.isDebugEnabled()) {
       LOG.debug("getReader:: Read ValidWriteIdList: " + validWriteIdList.toString()
             + " isTransactionalTable: " + HiveConf.getBoolVar(conf, ConfVars.HIVE_TRANSACTIONAL_TABLE_SCAN));

ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java

@@ -261,7 +261,7 @@ private VectorizedOrcAcidRowBatchReader(JobConf conf, OrcSplit orcSplit, Reporte
     }
 
     String txnString = conf.get(ValidWriteIdList.VALID_WRITEIDS_KEY);
-    this.validWriteIdList = (txnString == null) ? new ValidReaderWriteIdList() : new ValidReaderWriteIdList(txnString);
+    this.validWriteIdList = (txnString == null) ? new ValidReaderWriteIdList() : ValidReaderWriteIdList.fromValue(txnString);
     LOG.info("Read ValidWriteIdList: " + this.validWriteIdList.toString()
             + ":" + orcSplit);
 
@@ -788,7 +788,7 @@ static OrcSplit.OffsetAndBucketProperty computeOffsetAndBucket(
 
     String txnString = conf.get(ValidWriteIdList.VALID_WRITEIDS_KEY);
     ValidWriteIdList validWriteIdList = (txnString == null) ? new ValidReaderWriteIdList() :
-        new ValidReaderWriteIdList(txnString);
+        ValidReaderWriteIdList.fromValue(txnString);
 
     long rowIdOffset = 0;
     OrcRawRecordMerger.TransactionMetaData syntheticTxnInfo =
@@ -1243,7 +1243,7 @@ static class SortMergedDeleteEventRegistry implements DeleteEventRegistry {
         int bucket = AcidUtils.parseBucketId(orcSplit.getPath());
         String txnString = conf.get(ValidWriteIdList.VALID_WRITEIDS_KEY);
         this.validWriteIdList
-                = (txnString == null) ? new ValidReaderWriteIdList() : new ValidReaderWriteIdList(txnString);
+                = (txnString == null) ? new ValidReaderWriteIdList() : ValidReaderWriteIdList.fromValue(txnString);
         LOG.debug("Using SortMergedDeleteEventRegistry");
         Map<String, Integer> deltaToAttemptId = AcidUtils.getDeltaToAttemptIdMap(pathToDeltaMetaData, deleteDeltas, bucket);
         OrcRawRecordMerger.Options mergerOptions = new OrcRawRecordMerger.Options().isDeleteReader(true);
@@ -1926,7 +1926,8 @@ public BothWriteIds done(int index) {
       this.testMode = conf.getBoolean(ConfVars.HIVE_IN_TEST.varname, false);
       int bucket = AcidUtils.parseBucketId(orcSplit.getPath());
       String txnString = conf.get(ValidWriteIdList.VALID_WRITEIDS_KEY);
-      ValidWriteIdList validWriteIdList = (txnString == null) ? new ValidReaderWriteIdList() : new ValidReaderWriteIdList(txnString);
+      ValidWriteIdList validWriteIdList = (txnString == null) ? new ValidReaderWriteIdList()
+              : ValidReaderWriteIdList.fromValue(txnString);
       LOG.debug("Using ColumnizedDeleteEventRegistry");
       this.sortMerger = new TreeMap<>();
       this.rowIds = null;