Skip to content

Commit 2055879

Browse files
committed
Revert "HIVE-23931: Addendum: ValidWriteIdList isn't used by get_*_constraints HMS APIs (#6135)"
This reverts commit 809b2f9.
1 parent 809b2f9 commit 2055879

File tree

8 files changed

+197
-16
lines changed

8 files changed

+197
-16
lines changed

ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6640,8 +6640,10 @@ public List<SQLCheckConstraint> getCheckConstraintList(String dbName, String tbl
66406640
public SQLAllTableConstraints getTableConstraints(String dbName, String tblName, long tableId)
66416641
throws HiveException, NoSuchObjectException {
66426642
try {
6643+
ValidWriteIdList validWriteIdList = getValidWriteIdList(dbName, tblName);
66436644
AllTableConstraintsRequest request = new AllTableConstraintsRequest(dbName, tblName, getDefaultCatalog(conf));
66446645
request.setTableId(tableId);
6646+
request.setValidWriteIdList(validWriteIdList != null ? validWriteIdList.writeToString() : null);
66456647
return getMSC().getAllTableConstraints(request);
66466648
} catch (NoSuchObjectException e) {
66476649
throw e;
@@ -6656,7 +6658,10 @@ public TableConstraintsInfo getTableConstraints(String dbName, String tblName, b
66566658
perfLogger.perfLogBegin(CLASS_NAME, PerfLogger.HIVE_GET_TABLE_CONSTRAINTS);
66576659

66586660
try {
6661+
6662+
ValidWriteIdList validWriteIdList = getValidWriteIdList(dbName,tblName);
66596663
AllTableConstraintsRequest request = new AllTableConstraintsRequest(dbName, tblName, getDefaultCatalog(conf));
6664+
request.setValidWriteIdList(validWriteIdList != null ? validWriteIdList.writeToString() : null);
66606665
request.setTableId(tableId);
66616666

66626667
SQLAllTableConstraints tableConstraints = getMSC().getAllTableConstraints(request);

standalone-metastore/metastore-common/src/gen/thrift/gen-cpp/hive_metastore_types.cpp

Lines changed: 23 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

standalone-metastore/metastore-common/src/gen/thrift/gen-cpp/hive_metastore_types.h

Lines changed: 10 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)