MAPREDUCE-7522. Fix SpotBugs issues in hadoop-mapreduce-client-app module.

Author: slfan1989

hadoop-mapreduce-project/dev-support/findbugs-exclude.xml

@@ -554,4 +554,21 @@
     <Method name="onSuccess" />
     <Bug pattern="NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE" />
   </Match>
+
+  <Match>
+   <Class name="org.apache.hadoop.mapreduce.v2.app.job.impl.TaskAttemptImpl" />
+   <Bug pattern="CT_CONSTRUCTOR_THROW" />
+  </Match>
+  <Match>
+   <Class name="org.apache.hadoop.mapreduce.v2.app.speculate.DefaultSpeculator" />
+   <Bug pattern="CT_CONSTRUCTOR_THROW" />
+  </Match>
+  <Match>
+    <Class name="org.apache.hadoop.mapreduce.v2.app.webapp.dao.ConfInfo" />
+    <Bug pattern="CT_CONSTRUCTOR_THROW" />
+  </Match>
+  <Match>
+    <Class name="org.apache.hadoop.mapreduce.v2.app.webapp.dao.JobInfo" />
+    <Bug pattern="CT_CONSTRUCTOR_THROW" />
+  </Match>
  </FindBugsFilter>

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java

@@ -209,7 +209,7 @@ public class MRAppMaster extends CompositeService {
   protected JobTokenSecretManager jobTokenSecretManager =
       new JobTokenSecretManager();
   private JobId jobId;
-  private boolean newApiCommitter;
+  private volatile boolean newApiCommitter;
   private ClassLoader jobClassLoader;
   private OutputCommitter committer;
   private JobEventDispatcher jobEventDispatcher;

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/TaskHeartbeatHandler.java

@@ -77,7 +77,7 @@ public boolean isReported(){
   //received from a task.
   private Thread lostTaskCheckerThread;
   private volatile boolean stopped;
-  private long taskTimeOut;
+  private volatile long taskTimeOut;
   private long unregisterTimeOut;
   private long taskStuckTimeOut;
   private int taskTimeOutCheckInterval = 30 * 1000; // 30 seconds.

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/commit/CommitterEventHandler.java

@@ -338,7 +338,7 @@ private synchronized void waitForValidCommitWindow()
           @Override
           public void run() {
             synchronized (EventProcessor.this) {
-              EventProcessor.this.notify();
+              EventProcessor.this.notifyAll();
             }
           }
         });

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java

@@ -633,15 +633,15 @@ JobEventType.JOB_KILL, new KillTasksTransition())
   //changing fields while the job is running
   private int numMapTasks;
   private int numReduceTasks;
-  private int completedTaskCount = 0;
-  private int succeededMapTaskCount = 0;
+  private volatile int completedTaskCount = 0;
+  private volatile int succeededMapTaskCount = 0;
   private int succeededReduceTaskCount = 0;
   private int failedMapTaskCount = 0;
   private int failedReduceTaskCount = 0;
   private int killedMapTaskCount = 0;
   private int killedReduceTaskCount = 0;
   private long startTime;
-  private long finishTime;
+  private volatile long finishTime;
   private float setupProgress;
   private float mapProgress;
   private float reduceProgress;

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java

@@ -190,16 +190,16 @@ public abstract class TaskAttemptImpl implements
   private static Object commonContainerSpecLock = new Object();
   private static ContainerLaunchContext commonContainerSpec = null;
   private static final Object classpathLock = new Object();
-  private long launchTime;
-  private long finishTime;
+  private volatile long launchTime;
+  private volatile long finishTime;
   private WrappedProgressSplitsBlock progressSplitBlock;
-  private int shufflePort = -1;
+  private volatile int shufflePort = -1;
   private String trackerName;
-  private int httpPort;
+  private volatile int httpPort;
   private Locality locality;
   private Avataar avataar;
   private boolean rescheduleNextAttempt = false;
-  private boolean failFast = false;
+  private volatile boolean failFast = false;
 
   private static final CleanupContainerTransition
       CLEANUP_CONTAINER_TRANSITION = new CleanupContainerTransition();
@@ -648,7 +648,7 @@ TaskAttemptEventType.TA_CONTAINER_CLEANED, new TaskCleanupTransition())
     stateMachine;
 
   @VisibleForTesting
-  public Container container;
+  private Container container;
   private String nodeRackName;
   private WrappedJvmID jvmID;
 

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/launcher/ContainerLauncherImpl.java

@@ -74,7 +74,7 @@ public class ContainerLauncherImpl extends AbstractService implements
     new ConcurrentHashMap<ContainerId, Container>(); 
   private final AppContext context;
   protected ThreadPoolExecutor launcherPool;
-  protected int initialPoolSize;
+  protected volatile int initialPoolSize;
   private int limitOnPoolSize;
   private Thread eventHandlingThread;
   protected BlockingQueue<ContainerLauncherEvent> eventQueue =

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMCommunicator.java

@@ -69,7 +69,7 @@ public abstract class RMCommunicator extends AbstractService
     implements RMHeartbeatHandler {
   private static final Logger LOG =
       LoggerFactory.getLogger(RMCommunicator.class);
-  private int rmPollInterval;//millis
+  private volatile int rmPollInterval;//millis
   protected ApplicationId applicationId;
   private final AtomicBoolean stopped;
   protected Thread allocatorThread;
@@ -90,7 +90,7 @@ public abstract class RMCommunicator extends AbstractService
   // Has a signal (SIGTERM etc) been issued?
   protected volatile boolean isSignalled = false;
   private volatile boolean shouldUnregister = true;
-  private boolean isApplicationMasterRegistered = false;
+  private volatile boolean isApplicationMasterRegistered = false;
 
   private EnumSet<SchedulerResourceTypes> schedulerResourceTypes;
 

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java

@@ -165,15 +165,15 @@ added to the pending and are ramped up (added to scheduled) based
   private Resource mapResourceRequest = Resources.none();
   private Resource reduceResourceRequest = Resources.none();
 
-  private boolean reduceStarted = false;
+  private volatile boolean reduceStarted = false;
   private float maxReduceRampupLimit = 0;
-  private float maxReducePreemptionLimit = 0;
+  private volatile float maxReducePreemptionLimit = 0;
 
   // Mapper allocation timeout, after which a reducer is forcibly preempted
-  private long reducerUnconditionalPreemptionDelayMs;
+  private volatile long reducerUnconditionalPreemptionDelayMs;
 
   // Duration to wait before preempting a reducer when there is NO room
-  private long reducerNoHeadroomPreemptionDelayMs = 0;
+  private volatile long reducerNoHeadroomPreemptionDelayMs = 0;
 
   private float reduceSlowStart = 0;
   private int maxRunningMaps = 0;
@@ -1292,9 +1292,11 @@ private void containerAssigned(Container allocated,
     }
 
     private void containerNotAssigned(Container allocated) {
-      containersReleased++;
-      pendingRelease.add(allocated.getId());
-      release(allocated.getId());      
+      synchronized (RMContainerAllocator.this) {
+        containersReleased++;
+        pendingRelease.add(allocated.getId());
+        release(allocated.getId());
+      }
     }
 
     private ContainerRequest assignWithoutLocality(Container allocated) {

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerRequestor.java

@@ -97,13 +97,13 @@ public abstract class RMContainerRequestor extends RMCommunicator {
   private final Set<ResourceRequest> requestLimitsToUpdate =
       new TreeSet<ResourceRequest>(RESOURCE_REQUEST_COMPARATOR);
 
-  private boolean nodeBlacklistingEnabled;
-  private int blacklistDisablePercent;
+  private volatile boolean nodeBlacklistingEnabled;
+  private volatile int blacklistDisablePercent;
   private AtomicBoolean ignoreBlacklisting = new AtomicBoolean(false);
   private int blacklistedNodeCount = 0;
-  private int lastClusterNmCount = 0;
-  private int clusterNmCount = 0;
-  private int maxTaskFailuresPerNode;
+  private volatile int lastClusterNmCount = 0;
+  private volatile int clusterNmCount = 0;
+  private volatile int maxTaskFailuresPerNode;
   private final Map<String, Integer> nodeFailures = new HashMap<String, Integer>();
   private final Set<String> blacklistedNodes = Collections
       .newSetFromMap(new ConcurrentHashMap<String, Boolean>());