Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] UI should allow hyphen in fileset name #6399

Open
mchades opened this issue Feb 6, 2025 · 3 comments
Open

[Bug report] UI should allow hyphen in fileset name #6399

mchades opened this issue Feb 6, 2025 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mchades
Copy link
Contributor

mchades commented Feb 6, 2025

Version

main branch

Describe what's wrong

hyphen is allowed in the name spec:

/**
* Regular expression explanation:
*
* <p>^\w - Starts with a letter, digit, or underscore
*
* <p>[\w/=-]{0,63} - Followed by 0 to 63 characters (making the total length at most 64) of
* letters (both cases), digits, underscores, slashes, hyphens, or equals signs
*
* <p>$ - End of the string
*/
private static final String DEFAULT_NAME_PATTERN = "^\\w[\\w/=-]{0,63}$";

Error message and/or stacktrace

Image

How to reproduce

create a fileset by UI

Additional context

No response

@mchades mchades added the bug Something isn't working label Feb 6, 2025
@mchades
Copy link
Contributor Author

mchades commented Feb 6, 2025

@LauraXia123 cc

@jerryshao jerryshao added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 6, 2025
@LauraXia123
Copy link
Collaborator

@mchades only fileset name or all the catalog name?

@mchades
Copy link
Contributor Author

mchades commented Feb 12, 2025

only fileset name or all the catalog name?

all catalogs, you can test by API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants