Skip to content

Add per-scanner dimension for scanner metrics #3415

@charlesdong1991

Description

@charlesdong1991

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

ScannerMetricGroup scopes its metrics only by database and table, there is no per-scanner dimension. When two or more LogScanners run against the same database and table in the same client process, they all map to the same metric identity which could lead to wrong metric value to be reported.

Solution

Add a new dimension so concurrent scanners on the same table become distinct metric series, this will allow operators to alert with scenarios, e.g. something like max by (database, table), where any stuck scanner will dominate and report that value for alerting for instance.

Anything else?

Happy to contribute if team thinks reasonable.

Willingness to contribute

  • I'm willing to submit a PR!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels
    No fields configured for Feature.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions