Skip to content

[hotfix][javadocs] Fix typos in subpartition, ZooKeeper utils and sink ExecNode comments #28358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sherry255 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

[hotfix][javadocs] Fix typos in subpartition, ZooKeeper utils and sink ExecNode comments #28358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../java/org/apache/flink/runtime/io/network/partition/PipelinedApproximateSubpartition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

/**
* A pipelined in-memory only subpartition, which allows to reconnect after failure. Only one view
* is allowed at a time to read teh subpartition.
* is allowed at a time to read the subpartition.
*/
public class PipelinedApproximateSubpartition extends PipelinedSubpartition {

Expand Down
2 changes: 1 addition & 1 deletion flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,7 @@ public static String generateZookeeperPath(String... paths) {
* Splits the given ZooKeeper path into its parts.
*
* @param path path to split
* @return splited path
* @return split path
*/
public static String[] splitZooKeeperPath(String path) {
return path.split("/");
Expand Down
3 changes: 2 additions & 1 deletion ...r/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@
// Version 2: Fixed the data type used for creating constraint enforcer and sink upsert
// materializer. Since this version the sink works correctly with persisted metadata columns.
// We introduced a new version, because statements that were never rolling back to a value from
// state could run succesfully. We allow those jobs to be upgraded. Without a new versions such jobs
// state could run successfully. We allow those jobs to be upgraded. Without a new versions such
// jobs

@spuru9 spuru9 Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra line-break, should be contiguous?

// would fail on restore, because the state serializer would differ
@ExecNodeMetadata(
name = "stream-exec-sink",
Expand Down