Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] setting dubbo.application.metadata-type at config center does not take effect #14207

Closed
4 tasks done
zrlw opened this issue May 18, 2024 · 2 comments · Fixed by #14208
Closed
4 tasks done

[Bug] setting dubbo.application.metadata-type at config center does not take effect #14207

zrlw opened this issue May 18, 2024 · 2 comments · Fixed by #14208
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@zrlw
Copy link
Contributor

zrlw commented May 18, 2024

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

3.2.12

Steps to reproduce this issue

we want to change metdata store type of all our appliations to remote by setting dubbo.application.metadata-type(kebab-case) or dubbo.application.metadata_type(snake_case) at dubbo.properties on the config center (for mitigating the problems trigged by #14200).
but ConfigurationUtils#parseProperties will drop it because this property name just contains the string value type which is on the securityKey list.

What you expected to happen

setting metadataType by snake_case or kebab-case format on config center should not be prohibited.
or
checking property name is secure or not should not using contains judgement.

Anything else

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@zrlw zrlw added component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage labels May 18, 2024
@zrlw
Copy link
Contributor Author

zrlw commented May 20, 2024

AbstractConfiguratorListener#genConfiguratorsFromRawRule remove security parameters by calling URLParam#removeParameters which used Map.containsKey:

if (EXTRA_PARAMS.containsKey(key)) {  // the type of EXTRA_PARAMS is map.
   ...
   newExtraParams.remove(key);

should ConfigurationUtils do the same thing?
@AlbumenJ

@zrlw
Copy link
Contributor Author

zrlw commented May 20, 2024

ConfigurationUtils#parseProperties might judge whether property name is safe based on kebab-case comparison.

@github-project-automation github-project-automation bot moved this from Todo to Done in Dubbo Board May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant