Repository navigation
Conversation
### Background BE runtime statistics arrive asynchronously, so FE audit logging waits for final reports from the backends that received fragment dispatch attempts. The current implementation already supports generic participant tracking but also retains a separate coordinator and executor classification for external writes. ### What problem does this PR solve? Issue Number: None Related PR: apache#67053 (introduced external-write-specific audit tracking) PR Type: Refactor Problem Summary: Remove the external-DML-specific audit state, accessors, and executor-type checks. Table inserts use their existing shared execution coordinator, and FILES inserts publish their coordinator through the same statement execution state. Audit participants come from dispatched backend IDs and the existing query-scoped failure snapshot. ### Details - **Moves vs. logic changes:** Remove the duplicate external-write coordinator registration and classification helper. Rename the scheduler participant accessor to `getDispatchedBackendIds()` and update its callers and tests. - **Behavior change:** FILES inserts publish the execution coordinator through `StmtExecutor.setCoord()`, sharing the existing audit and cancellation handoff. Participant selection, final-report waiting, timeout fallback, and failure snapshots retain their existing rules. - **Compatibility:** No Thrift field IDs, types, or optionality change; the forwarding-field edit only updates its comment. No storage format changes. - **Performance impact:** Remove an extra retained coordinator reference and an extra participant source. No additional threads, locks, queues, or waits. - **Rollback:** Revert this PR; no migration is required. ### Testing - Locally ran `run-fe-ut.sh --run` for eight suites: `AuditLogHelperBackendSelectionTest`, `MasterOpExecutorBackendSelectionTest`, `PipelineExecutionTaskTest`, `WorkloadRuntimeStatusMgrTest`, `InsertIntoTableCommandTest`, `InsertIntoTVFCommandTest`, `OlapInsertExecutorTest`, and `StreamingInsertTaskAuditTest`: 76 tests passed, with no failures, errors, or skips. - The two new FILES command tests failed before the change because the standard coordinator was absent. Both now pass and cover successful execution, partial dispatch failure, retained participants, and coordinator cleanup. - FE Checkstyle: zero violations. - `git diff --check`: passed. ### Release note None ### Check List (For Author) - Behavior changed: Yes (see Details) - Does this need documentation: No - Pre-submission status: Ready ### AI Disclosure - Tool: Codex (GPT-6) - Generated: Code changes, tests, and this description. - Human review: Pending.
Gabriel39
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
November 13, 2026 03:39
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
BE runtime statistics arrive asynchronously, so FE audit logging waits for final reports from the backends that received fragment dispatch attempts. The current implementation already supports generic participant tracking but also retains a separate coordinator and executor classification for external writes.
What problem does this PR solve?
Issue Number: None
Related PR: #67053 (introduced external-write-specific audit tracking)
PR Type: Refactor
Problem Summary:
Remove the external-DML-specific audit state, accessors, and executor-type checks. Table inserts use their existing shared execution coordinator, and FILES inserts publish their coordinator through the same statement execution state. Audit participants come from dispatched backend IDs and the existing query-scoped failure snapshot.
Details
getDispatchedBackendIds()and update its callers and tests.StmtExecutor.setCoord(), sharing the existing audit and cancellation handoff. Participant selection, final-report waiting, timeout fallback, and failure snapshots retain their existing rules.Testing
run-fe-ut.sh --runfor eight suites:AuditLogHelperBackendSelectionTest,MasterOpExecutorBackendSelectionTest,PipelineExecutionTaskTest,WorkloadRuntimeStatusMgrTest,InsertIntoTableCommandTest,InsertIntoTVFCommandTest,OlapInsertExecutorTest, andStreamingInsertTaskAuditTest: 76 tests passed, with no failures, errors, or skips.git diff --check: passed.Release note
None
Check List (For Author)
AI Disclosure