[fix](variant) normalize legacy single-part dot-key subcolumn paths on read#62409
Open
csun5285 wants to merge 1 commit intoapache:masterfrom
Open
[fix](variant) normalize legacy single-part dot-key subcolumn paths on read#62409csun5285 wants to merge 1 commit intoapache:masterfrom
csun5285 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
f741251 to
3f07adb
Compare
…n read
Old versions (cloud-4.1.2 with variant_max_subcolumns_count=0) store a
flat JSON key like {"a.b": 1} as a single PathInData part "a.b" in the
segment's ColumnPathInfo protobuf. New master compaction builds query
paths via PathInData(string) which splits on dots, so the 3-part path
does not match the 1-part tree node, find_leaf returns nullptr, and the
read plan silently falls back to DEFAULT_FILL. Compaction then rewrites
the rowset with empty values, losing the original data.
Normalize the legacy relative path in VariantColumnReader::init() by
re-constructing PathInData from its string form. This splits the
single-part dot key into multiple parts so the meta tree shape matches
what both compaction schema and query path expect.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3f07adb to
2854be5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old versions (cloud-4.1.2 with variant_max_subcolumns_count=0) store a flat JSON key like {"a.b": 1} as a single PathInData part "a.b" in the segment's ColumnPathInfo protobuf. New master compaction builds query paths via PathInData(string) which splits on dots, so the 3-part path does not match the 1-part tree node, find_leaf returns nullptr, and the read plan silently falls back to DEFAULT_FILL. Compaction then rewrites the rowset with empty values, losing the original data.
Normalize the legacy relative path in VariantColumnReader::init() by re-constructing PathInData from its string form. This splits the single-part dot key into multiple parts so the meta tree shape matches what both compaction schema and query path expect.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)