Skip to content

[fix](variant) normalize legacy single-part dot-key subcolumn paths on read#62409

Open
csun5285 wants to merge 1 commit intoapache:masterfrom
csun5285:fix/variant-dot-key-access
Open

[fix](variant) normalize legacy single-part dot-key subcolumn paths on read#62409
csun5285 wants to merge 1 commit intoapache:masterfrom
csun5285:fix/variant-dot-key-access

Conversation

@csun5285
Copy link
Copy Markdown
Contributor

Old versions (cloud-4.1.2 with variant_max_subcolumns_count=0) store a flat JSON key like {"a.b": 1} as a single PathInData part "a.b" in the segment's ColumnPathInfo protobuf. New master compaction builds query paths via PathInData(string) which splits on dots, so the 3-part path does not match the 1-part tree node, find_leaf returns nullptr, and the read plan silently falls back to DEFAULT_FILL. Compaction then rewrites the rowset with empty values, losing the original data.

Normalize the legacy relative path in VariantColumnReader::init() by re-constructing PathInData from its string form. This splits the single-part dot key into multiple parts so the meta tree shape matches what both compaction schema and query path expect.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Apr 12, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@csun5285
Copy link
Copy Markdown
Contributor Author

run buildall

@csun5285 csun5285 force-pushed the fix/variant-dot-key-access branch 2 times, most recently from f741251 to 3f07adb Compare April 13, 2026 02:35
…n read

Old versions (cloud-4.1.2 with variant_max_subcolumns_count=0) store a
flat JSON key like {"a.b": 1} as a single PathInData part "a.b" in the
segment's ColumnPathInfo protobuf. New master compaction builds query
paths via PathInData(string) which splits on dots, so the 3-part path
does not match the 1-part tree node, find_leaf returns nullptr, and the
read plan silently falls back to DEFAULT_FILL. Compaction then rewrites
the rowset with empty values, losing the original data.

Normalize the legacy relative path in VariantColumnReader::init() by
re-constructing PathInData from its string form. This splits the
single-part dot key into multiple parts so the meta tree shape matches
what both compaction schema and query path expect.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@csun5285 csun5285 force-pushed the fix/variant-dot-key-access branch from 3f07adb to 2854be5 Compare April 13, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants