feat: be indifferent to padding when decoding base64 #18264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
colinmarc
force-pushed
the
base64-decode-padding
branch
from
b765cc8 to
28d1f32
Compare
Padding isn't required to decode correctly, but it's surprising to users if we just reject it outright.
colinmarc
force-pushed
the
base64-decode-padding
branch
from
28d1f32 to
2b95390
Compare
Jefffrey
approved these changes
Oct 24, 2025
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
The fix for decoding makes sense (TIL padding isn't strictly required)
Though for encoding, is it better to keep padding for wider compatibility?
Contributor
Author
|
That could break existing queries, since the existing implementation doesn't add padding, so I didn't make the change. (But I'm not opposed if you'd like me to add it). |
Contributor
Ah disregard me, I read the docs wrong 😅 I thought the All good 👍 |
26 tasks
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
This changes the `decode` built-in function so that SQL like the
following works:
```sql
decode('cXdlcXc=', 'base64');
```
Padding isn't required to decode correctly, but it's surprising to users
if we just reject it outright.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
decodebuilt-in function so that SQL like the following works:Padding isn't required to decode correctly, but it's surprising to users if we just reject it outright.