Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #78

Open
2 tasks
brodycj opened this issue Oct 21, 2019 · 2 comments
Open
2 tasks

Cleanup #78

brodycj opened this issue Oct 21, 2019 · 2 comments

Comments

@brodycj
Copy link

brodycj commented Oct 21, 2019

From review of PR #56 (watch2 support), I have a feeling that we should be able to clean up both the source code and all of the tests. I am raising this for future consideration and discussion.

Starting to add a list:

/cc @l3ender

@l3ender
Copy link
Contributor

l3ender commented Oct 21, 2019

Regarding code readability, are you thinking to enhance dependency lookup ability, or a more general thought? If the former, I have a few thoughts based on work in #76:

  • Xcode links dependencies sort of messily, but helper functions could be exposed to help with this.
  • The addTarget function could/should expose easier data about any generated dependencies it adds via addTargetDependency (the new UUIDs generated from addTargetDependency aren't in turn exposed through the response object of addTarget).

@brodycj
Copy link
Author

brodycj commented Oct 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants