From fa7e114c2a3003d92411869270b9405e2db5e61f Mon Sep 17 00:00:00 2001 From: Ramgopal Nagaboina Date: Thu, 3 Sep 2026 19:48:09 -0400 Subject: [PATCH] api: remove unused equals/hashCode from TemplateOVFPropertyResponse TemplateOVFPropertyResponse is not referenced anywhere outside its own class: nothing keys it in a set or map or compares instances, so its equals()/hashCode() pair has no callers. hashCode() also dereferenced key without a null guard. Remove both methods rather than harden dead code, which also drops the NPE path. --- .../api/response/TemplateOVFPropertyResponse.java | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/api/src/main/java/org/apache/cloudstack/api/response/TemplateOVFPropertyResponse.java b/api/src/main/java/org/apache/cloudstack/api/response/TemplateOVFPropertyResponse.java index 715d0e980ef4..8520d0035b70 100644 --- a/api/src/main/java/org/apache/cloudstack/api/response/TemplateOVFPropertyResponse.java +++ b/api/src/main/java/org/apache/cloudstack/api/response/TemplateOVFPropertyResponse.java @@ -66,19 +66,6 @@ public class TemplateOVFPropertyResponse extends BaseResponse { @Param(description = "The ovf property category") private String category; - @Override - public boolean equals(Object other) { - if (!(other instanceof TemplateOVFPropertyResponse)) { - return false; - } - return key != null && key.equals(((TemplateOVFPropertyResponse)other).key); - } - - @Override - public int hashCode() { - return key.hashCode(); - } - public String getKey() { return key; }