Quota UI rework by winterhazel · Pull Request #13449 · apache/cloudstack

winterhazel · 2026-06-18T13:17:56Z

Description

This PR is a rework of the Quota UI intended to expose the new functionality added in #9590, #10505, #10506, #12961, and #13236, as well as provide a better visualization of the Quota-related statistics.

With these changes, it is now possible to:

Visualize the Quota consumption of Accounts/Projects throughout multiple periods of time.
See which resources are responsible for the Quota consumption, and which tariffs were applied.
Visualize how the balance of an Account/Project changed throughout multiple periods of time.
Visualize the credits addition history of Accounts/Projects.

Additionally, some changes were made in quotaCredits and quotaCreditsList to allow adding credits to and obtaining the credits addition history for Projects, which has also been exposed in the UI. A new field was also added to the response of quotaStatement to allow seeing the consumption history as a line chart.

Closes #11805.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Screenshots (if appropriate):

2026-06-18.10-02-25.mp4

How Has This Been Tested?

I manually tested these changes by accessing the summary (consumption, balance, and credits), tariff, and email template pages for admin, domain admin, users, and projects (when applicable) and validating that the expected contents were shown. The credits addition and listing was also tested.

github-actions · 2026-06-24T12:09:11Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

codecov · 2026-06-24T12:09:47Z

Codecov Report

❌ Patch coverage is 70.54264% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.93%. Comparing base (82986f6) to head (14a9f8b).
⚠️ Report is 40 commits behind head on main.

Files with missing lines	Patch %	Lines
...udstack/api/response/QuotaResponseBuilderImpl.java	81.01%	12 Missing and 3 partials ⚠️
...he/cloudstack/api/command/QuotaCreditsListCmd.java	0.00%	8 Missing ⚠️
...apache/cloudstack/api/command/QuotaCreditsCmd.java	14.28%	6 Missing ⚠️
...ache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java	0.00%	4 Missing ⚠️
...i/response/QuotaStatementItemResourceResponse.java	0.00%	3 Missing ⚠️
...pi/response/QuotaStatementItemHistoryResponse.java	95.83%	0 Missing and 1 partial ⚠️
...c/main/java/com/cloud/user/AccountManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13449      +/-   ##
============================================
- Coverage     18.94%   18.93%   -0.01%     
- Complexity    18363    18481     +118     
============================================
  Files          6192     6227      +35     
  Lines        556361   560407    +4046     
  Branches      67908    68311     +403     
============================================
+ Hits         105397   106110     +713     
- Misses       439393   442673    +3280     
- Partials      11571    11624      +53

Flag	Coverage Δ
uitests	`3.47% <ø> (-0.05%)`	⬇️
unittests	`20.15% <70.54%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… one

weizhouapache · 2026-06-30T12:12:14Z

@winterhazel
is this in progress ?

winterhazel · 2026-06-30T13:47:44Z

@winterhazel is this in progress ?

@weizhouapache it is ready.

winterhazel · 2026-06-30T13:48:07Z

@blueorangutan package

blueorangutan · 2026-06-30T13:50:04Z

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-06-30T14:43:59Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18419

winterhazel · 2026-06-30T14:48:18Z

@blueorangutan ui

blueorangutan · 2026-06-30T14:49:04Z

@winterhazel a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-06-30T15:08:56Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13449 (QA-JID-957)

winterhazel · 2026-07-01T19:15:55Z

@weizhouapache can we run the CI here?

weizhouapache · 2026-07-01T19:51:52Z

@blueorangutan test

blueorangutan · 2026-07-01T19:54:05Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Copilot

Pull request overview

This PR reworks the Quota UI to surface recent Quota API enhancements (multi-period visualization, resource-level breakdown, balance and credits history) and extends backend quota responses to include consumption history and improved credits handling (including projects).

Changes:

Replaced the legacy Quota Summary/Usage/Balance UI views with new tabbed views supporting period filtering, charts, and CSV export.
Extended quota statement/statement-item responses with history to enable line charts for consumption over time.
Refactored quota credits add/list flows (UI + API) to better support projects and enforcement/min-balance behavior.

Reviewed changes

Copilot reviewed 44 out of 45 changed files in this pull request and generated 18 comments.

Show a summary per file

File	Description
ui/src/views/plugins/quota/QuotaUsageTab.vue	New usage tab with charts, resource drill-down, and export
ui/src/views/plugins/quota/QuotaUsage.vue	Removed legacy quota usage view
ui/src/views/plugins/quota/QuotaSummaryResource.vue	Removed legacy summary resource wrapper
ui/src/views/plugins/quota/QuotaSummary.vue	Removed legacy summary page wrapper
ui/src/views/plugins/quota/QuotaCreditTab.vue	New credits history tab with chart and export
ui/src/views/plugins/quota/QuotaBalanceTab.vue	New balance history tab with chart and export
ui/src/views/plugins/quota/QuotaBalance.vue	Removed legacy quota balance view
ui/src/views/plugins/quota/FilterQuotaDataByPeriodView.vue	New shared period selector (preset + custom range)
ui/src/views/plugins/quota/EditTariffValueWizard.vue	Removed legacy tariff edit wizard
ui/src/views/plugins/quota/EditQuotaTariff.vue	Minor UI cleanup (class removals)
ui/src/views/plugins/quota/CreateQuotaTariff.vue	Minor UI cleanup (class removals)
ui/src/views/plugins/quota/AddQuotaCredit.vue	New quota credits add popup using ownership selection
ui/src/views/AutogenView.vue	QuotaSummary param handling + quota tariff column adjustment
ui/src/utils/units.js	Added shared time-unit constants
ui/src/utils/quota.js	Added chart colors + quota type lookup helper
ui/src/utils/export.js	Added CSV export helper
ui/src/utils/date.js	Extracted timezone-offset helper
ui/src/utils/chart.js	Added chart helpers (time axis unit selection + colors)
ui/src/style/common/common.scss	Added common utility classes used by new UI
ui/src/config/section/plugin/quota.js	Rewired quota sections/tabs/actions to new components
ui/src/components/view/stats/ResourceStatsLineChart.vue	Allow per-dataset `fill` override
ui/src/components/view/ListView.vue	Adjusted quota summary account linking and email template linking
ui/src/components/view/InfoCard.vue	Show quota currency/balance fields; adjust project display
ui/src/components/view/DetailsTab.vue	Syntax highlighting for activationRule
ui/src/components/view/charts/BarChart.vue	New reusable BarChart wrapper
ui/src/components/view/buttons/ExportToCsvButton.vue	New reusable export button
ui/src/api/index.js	Allow `quotaEmailTemplateList` via GET API list
ui/public/locales/pt_BR.json	Added/updated quota UI strings
ui/public/locales/en.json	Added/updated quota UI strings
ui/package.json	Added `vue-code-highlight` dependency
ui/jest.config.js	Allow prism transform for tests
server/src/main/java/com/cloud/user/AccountManagerImpl.java	Minor message cleanup in finalizeAccountId
plugins/database/quota/src/test/java/org/apache/cloudstack/api/response/QuotaResponseBuilderImplTest.java	Updated/expanded quota response builder tests
plugins/database/quota/src/test/java/org/apache/cloudstack/api/command/QuotaCreditsCmdTest.java	Updated credits command test for new builder signature
plugins/database/quota/src/main/java/org/apache/cloudstack/api/response/QuotaStatementItemResponse.java	Added `history` field to statement item
plugins/database/quota/src/main/java/org/apache/cloudstack/api/response/QuotaStatementItemResourceResponse.java	Added `history` field to resource statement item
plugins/database/quota/src/main/java/org/apache/cloudstack/api/response/QuotaStatementItemHistoryResponse.java	New response type for consumption history
plugins/database/quota/src/main/java/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java	Credits refactor + history generation
plugins/database/quota/src/main/java/org/apache/cloudstack/api/response/QuotaResponseBuilder.java	Updated credits API to accept command object
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaCreditsListCmd.java	Added `projectid`, recursion handling, owner resolution
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaCreditsCmd.java	Added accountid/projectid support; refactored execute path
framework/quota/src/main/java/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java	Credits query signature refactor (domainIds list)
framework/quota/src/main/java/org/apache/cloudstack/quota/dao/QuotaCreditsDao.java	Updated DAO method signature
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java	Added `HISTORY` constant

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Quota UI rework

e335605

winterhazel added this to the 4.23.0 milestone Jun 18, 2026

boring-cyborg Bot added component:api component:quota component:UI labels Jun 18, 2026

Fix license

19e60ab

winterhazel added status:needs-testing status:needs-review labels Jun 18, 2026

bernardodemarco self-requested a review June 18, 2026 16:55

github-actions Bot added the status:has-conflicts label Jun 24, 2026

winterhazel added 3 commits June 24, 2026 21:38

QuotaUsageTab.vue refactoring

6cda0d4

Solve Vue warnings

617bd64

Merge remote-tracking branch 'origin/main' into quota-ui

54ce551

github-actions Bot removed the status:has-conflicts label Jun 25, 2026

winterhazel added 3 commits June 24, 2026 22:25

Fix failing tests

cc7db60

Allow obtaining a color for usage types that do not have a predefined…

c2b19a8

… one

Remove unused imports

6fb8708

jest: transpile Prism

2b4600a

winterhazel marked this pull request as ready for review June 30, 2026 13:47

winterhazel requested a review from erikbocks June 30, 2026 14:00

weizhouapache requested a review from Copilot July 1, 2026 19:51

Copilot started reviewing on behalf of weizhouapache July 1, 2026 19:51 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Address copilot reviews

14a9f8b

Uh oh!

Conversation

winterhazel commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

codecov Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache commented Jun 30, 2026

Uh oh!

winterhazel commented Jun 30, 2026

Uh oh!

winterhazel commented Jun 30, 2026

Uh oh!

blueorangutan commented Jun 30, 2026

Uh oh!

blueorangutan commented Jun 30, 2026

Uh oh!

winterhazel commented Jun 30, 2026

Uh oh!

blueorangutan commented Jun 30, 2026

Uh oh!

blueorangutan commented Jun 30, 2026

Uh oh!

winterhazel commented Jul 1, 2026

Uh oh!

weizhouapache commented Jul 1, 2026

Uh oh!

blueorangutan commented Jul 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

winterhazel commented Jun 18, 2026 •

edited

Loading

codecov Bot commented Jun 24, 2026 •

edited

Loading