Skip to content

Commit 8ff694a

Browse files
authored
Apply suggestions from code review
1 parent 84be387 commit 8ff694a

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ private void matchNicsToNets(Map<String, OVFNetworkTO> nets, Node systemElement)
541541
nicCount++;
542542
String name = e.getTextContent(); // should be in our nets
543543
if(nets.get(name) == null) {
544-
logger.info("Found a nic definition without a network definition byname {}, adding it to the list.", name);
544+
logger.info("Found a nic definition without a network definition by name {}, adding it to the list.", name);
545545
nets.put(name, new OVFNetworkTO());
546546
}
547547
OVFNetworkTO thisNet = nets.get(name);

api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ public void create() {
255255
}
256256
} catch (NetworkRuleConflictException ex) {
257257
String message = "Network rule conflict: ";
258-
logger.error( "Network rule conflict: {}", ex.getMessage());
258+
logger.error("{}{}", message, ex.getMessage());
259259
logger.trace(message, ex);
260260
throw new ServerApiException(ApiErrorCode.NETWORK_RULE_CONFLICT_ERROR, ex.getMessage());
261261
}

api/src/main/java/org/apache/cloudstack/context/LogContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ public static void unregister() {
205205
LogContext context = s_currentContext.get();
206206
if (context != null) {
207207
s_currentContext.remove();
208-
LOGGER.trace("Unregistered: {}", () -> context);
208+
LOGGER.trace("Unregistered: {}", context);
209209
}
210210
ThreadContext.clearMap();
211211
}

0 commit comments

Comments
 (0)