address review comments

Author: sudo87

api/src/main/java/org/apache/cloudstack/api/response/LoginCmdResponse.java

@@ -92,7 +92,7 @@ public class LoginCmdResponse extends AuthenticationCmdResponse {
 
     @SerializedName(value = ApiConstants.PASSWORD_CHANGE_REQUIRED)
     @Param(description = "Indicates whether the User is required to change password on next login.", since = "4.23.0")
-    private String passwordChangeRequired;
+    private Boolean passwordChangeRequired;
 
     public String getUsername() {
         return username;
@@ -228,11 +228,11 @@ public void setManagementServerId(String managementServerId) {
         this.managementServerId = managementServerId;
     }
 
-    public String getPasswordChangeRequired() {
+    public Boolean getPasswordChangeRequired() {
         return passwordChangeRequired;
     }
 
     public void setPasswordChangeRequired(String passwordChangeRequired) {
-        this.passwordChangeRequired = passwordChangeRequired;
+        this.passwordChangeRequired = Boolean.parseBoolean(passwordChangeRequired);
     }
 }

ui/src/store/modules/user.js

@@ -511,7 +511,6 @@ const user = {
         vueProps.$localStorage.remove(ACCESS_TOKEN)
         vueProps.$localStorage.remove(HEADER_NOTICES)
 
-        vueProps.$localStorage.remove(PASSWORD_CHANGE_REQUIRED)
         commit('SET_PASSWORD_CHANGE_REQUIRED', false)
 
         logout(state.token).then(() => {