Skip to content

Commit 04af974

Browse files
author
Pearl Dsilva
committed
increase lv cmd timeouts to consider cluster load
1 parent ae98107 commit 04af974

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

core/src/main/java/org/apache/cloudstack/storage/clvm/command/ClvmLockTransferCommand.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public ClvmLockTransferCommand(Operation operation, String lvPath, String volume
7777
this.operation = operation;
7878
this.lvPath = lvPath;
7979
this.volumeUuid = volumeUuid;
80-
setWait(30);
80+
setWait(65);
8181
}
8282

8383
public String getLvPath() {

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5760,7 +5760,7 @@ private Answer listLvmVolumes(String localPath, int startIndex, int pageSize) {
57605760
}
57615761
}
57625762

5763-
Script lvs = new Script("lvs", 10000, logger);
5763+
Script lvs = new Script("lvs", 30000, logger);
57645764
lvs.add("--noheadings");
57655765
lvs.add("--nosuffix");
57665766
lvs.add("-o", "lv_name,lv_size");
@@ -7092,7 +7092,7 @@ static boolean checkIfVolumeGroupIsClustered(String vgName) {
70927092

70937093
try {
70947094
OutputInterpreter.AllLinesParser parser = new OutputInterpreter.AllLinesParser();
7095-
Script vgsCmd = new Script("vgs", 10000, LOGGER);
7095+
Script vgsCmd = new Script("vgs", 30000, LOGGER);
70967096
vgsCmd.add("--noheadings");
70977097
vgsCmd.add("--unbuffered");
70987098
vgsCmd.add("-o");

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtClvmLockTransferCommandWrapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public Answer execute(ClvmLockTransferCommand cmd, LibvirtComputingResource serv
6464
return new ClvmLockTransferAnswer(cmd, false, "Unknown operation: " + operation);
6565
}
6666

67-
Script script = new Script("/usr/sbin/lvchange", 30000, logger);
67+
Script script = new Script("/usr/sbin/lvchange", 60000, logger);
6868
script.add(lvchangeOpt);
6969
script.add(lvPath);
7070

@@ -103,7 +103,7 @@ public Answer execute(ClvmLockTransferCommand cmd, LibvirtComputingResource serv
103103
*/
104104
private Answer handleQueryLockState(ClvmLockTransferCommand cmd, String lvPath, String volumeUuid) {
105105
try {
106-
Script script = new Script("/usr/sbin/lvs", 10000, logger);
106+
Script script = new Script("/usr/sbin/lvs", 30000, logger);
107107
script.add("-o");
108108
script.add("lv_attr,lv_host");
109109
script.add("--noheadings");

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ public KVMPhysicalDisk createPhysicalDisk(String name, KVMStoragePool pool,
172172
public boolean connectPhysicalDisk(String name, KVMStoragePool pool, Map<String, String> details, boolean isVMMigrate) {
173173
if (isVMMigrate) {
174174
logger.info("Activating CLVM/CLVM_NG volume {} in shared mode for VM migration", name);
175-
Script activateVol = new Script("lvchange", 10000, logger);
175+
Script activateVol = new Script("lvchange", 30000, logger);
176176
activateVol.add("-asy");
177177
activateVol.add(pool.getLocalPath() + File.separator + name);
178178
String result = activateVol.execute();
@@ -266,7 +266,7 @@ private StoragePool createCLVMStoragePool(Connect conn, String uuid, String host
266266
String volgroupName = path;
267267
volgroupName = volgroupName.replaceFirst("^/", "");
268268

269-
Script checkVgExists = new Script("vgs", 10000, logger);
269+
Script checkVgExists = new Script("vgs", 30000, logger);
270270
checkVgExists.add("--noheadings");
271271
checkVgExists.add("-o", "vg_name");
272272
checkVgExists.add(volgroupName);
@@ -312,7 +312,7 @@ private void setPoolCapacityFromVgStats(LibvirtStoragePool pool, long[] vgStats,
312312
}
313313

314314
private long[] getVgStats(String vgName) {
315-
Script getVgStats = new Script("vgs", 10000, logger);
315+
Script getVgStats = new Script("vgs", 30000, logger);
316316
getVgStats.add("--noheadings");
317317
getVgStats.add("--units", "b");
318318
getVgStats.add("--nosuffix");
@@ -466,7 +466,7 @@ private KVMPhysicalDisk getPhysicalDiskViaDirectBlockDevice(String volumeUuid, K
466466

467467
private void verifyLvExistsInVg(String volumeUuid, String vgName) {
468468
logger.debug("Checking if volume {} exists in VG {}", volumeUuid, vgName);
469-
Script checkLvCmd = new Script("/usr/sbin/lvs", 10000, logger);
469+
Script checkLvCmd = new Script("/usr/sbin/lvs", 30000, logger);
470470
checkLvCmd.add("--noheadings");
471471
checkLvCmd.add("--unbuffered");
472472
checkLvCmd.add(vgName + "/" + volumeUuid);
@@ -547,7 +547,7 @@ private void ensureTemplateAccessibility(String volumeUuid, String lvPath, KVMSt
547547

548548
private long getClvmVolumeSize(String lvPath) {
549549
try {
550-
Script lvsCmd = new Script("/usr/sbin/lvs", 10000, logger);
550+
Script lvsCmd = new Script("/usr/sbin/lvs", 30000, logger);
551551
lvsCmd.add("--noheadings");
552552
lvsCmd.add("--units");
553553
lvsCmd.add("b");
@@ -666,7 +666,7 @@ private String getClvmBackingFile(KVMPhysicalDisk template, KVMStoragePool destP
666666
*/
667667
private void ensureTemplateLvInSharedMode(String templatePath, boolean throwOnFailure) {
668668
try {
669-
Script checkLvs = new Script("lvs", Duration.millis(10000), logger);
669+
Script checkLvs = new Script("lvs", Duration.millis(30000), logger);
670670
checkLvs.add("--noheadings");
671671
checkLvs.add("-o", "lv_attr");
672672
checkLvs.add(templatePath);
@@ -881,7 +881,7 @@ private KVMPhysicalDisk createClvmNgDiskWithBacking(String volumeUuid, int timeo
881881
}
882882

883883
private boolean lvExists(String lvPath) {
884-
Script checkLv = new Script("lvs", Duration.millis(10000), logger);
884+
Script checkLv = new Script("lvs", Duration.millis(30000), logger);
885885
checkLv.add("--noheadings");
886886
checkLv.add("--unbuffered");
887887
checkLv.add(lvPath);
@@ -953,7 +953,7 @@ private boolean cleanupCLVMVolume(String uuid, KVMStoragePool pool) {
953953
String lvPath = "/dev/" + vgName + "/" + uuid;
954954
logger.debug("Volume path: {}", lvPath);
955955

956-
Script checkLvs = new Script("lvs", 10000, logger);
956+
Script checkLvs = new Script("lvs", 30000, logger);
957957
checkLvs.add("--noheadings");
958958
checkLvs.add("--unbuffered");
959959
checkLvs.add(lvPath);

0 commit comments

Comments
 (0)