Skip to content

Commit 4914cf7

Browse files
committed
CASSJAVA-57 Filter comment lines out when reading in comparison files
patch by Bret McGuire; reviewed by Bret McGuire for CASSJAVA-57
1 parent 657e470 commit 4914cf7

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

driver-core/src/test/java/com/datastax/driver/core/ExportAsStringTest.java

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@
2323
import com.datastax.driver.core.schemabuilder.SchemaBuilder;
2424
import com.datastax.driver.core.utils.CassandraVersion;
2525
import com.google.common.collect.ImmutableMap;
26-
import com.google.common.io.ByteStreams;
2726
import com.google.common.io.Closer;
28-
import java.io.ByteArrayOutputStream;
27+
import java.io.BufferedReader;
2928
import java.io.IOException;
3029
import java.io.InputStream;
31-
import java.io.PrintStream;
30+
import java.io.InputStreamReader;
31+
import java.io.StringWriter;
3232
import java.util.Map;
3333
import org.slf4j.Logger;
3434
import org.slf4j.LoggerFactory;
@@ -248,10 +248,19 @@ private String getExpectedCqlString() {
248248
+ ")")
249249
.isNotNull();
250250
closer.register(is);
251-
ByteArrayOutputStream baos = new ByteArrayOutputStream();
252-
PrintStream ps = new PrintStream(baos);
253-
ByteStreams.copy(is, ps);
254-
return baos.toString().trim();
251+
252+
BufferedReader in = new BufferedReader(new InputStreamReader(is));
253+
StringWriter out = new StringWriter();
254+
255+
String line;
256+
while ((line = in.readLine()) != null) {
257+
258+
String trimmedLine = line.trim();
259+
if (trimmedLine.startsWith("/*") || trimmedLine.startsWith("*")) continue;
260+
out.write(line);
261+
out.write(System.getProperty("line.separator"));
262+
}
263+
return out.toString().trim();
255264
} catch (IOException e) {
256265
logger.warn("Failure to read {}", resourceName, e);
257266
fail("Unable to read " + resourceName + " is it defined?");

0 commit comments

Comments
 (0)