You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/hacking-guide/_maintainers.adoc
+6-6Lines changed: 6 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -7,10 +7,10 @@ However, the expectation here is that the developer has made a good effort to te
7
7
8
8
What does it mean to be reasonably confident?
9
9
If the developer has run the same maven commands that the pull-request builds are running they can be reasonably confident.
10
-
Currently the https://builds.apache.org/job/ActiveMQ-Artemis-PR-Build/[PR build] runs this command:
10
+
Currently the https://github.com/apache/artemis/blob/main/.github/workflows/build.yml[PR build] runs this command:
11
11
[,console]
12
12
----
13
-
$ mvn -Pfast-tests install
13
+
$ mvn -Pfast-tests -Pcompatibility-tests install
14
14
----
15
15
However, if the changes are significant, touches a wide area of code, or even if the developer just wants a second opinion they are encouraged to engage other members of the community to obtain an additional review prior to pushing.
16
16
This can easily be done via a pull request on GitHub, a patch file attached to an email or JIRA, commit to a branch in the Apache git repo, etc.
@@ -36,7 +36,7 @@ This format follows the recommendation from the https://git-scm.com/book/en/v2/D
36
36
Aside from the traditional `origin` and `upstream` repositories committers will need an additional reference for the canonical Apache git repository where they will be merging and pushing pull-requests.
37
37
For the purposes of this document, let's assume these ref/repo associations already exist as described in the xref:code.adoc[Working with the Code] section:
Copy file name to clipboardExpand all lines: docs/hacking-guide/_tests.adoc
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -36,7 +36,7 @@ A simple test like this takes less than a second to run on modern hardware.
36
36
37
37
Although `org.apache.activemq.artemis.tests.integration.SimpleTest` is simple it could be simpler still by extending https://github.com/apache/artemis/blob/main/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/SingleServerTestBase.java[`org.apache.activemq.artemis.tests.util.SingleServerTestBase`].
38
38
This class does all the setup of a simple server automatically and provides the test-case with a `ServerLocator`, `ClientSessionFactory`, and `ClientSession` instance.
39
-
https://github.com/apache/artemis/blob/main//tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/SingleServerSimpleTest.java[`org.apache.activemq.artemis.tests.integration.SingleServerSimpleTest`] is an example based on `org.apache.activemq.artemis.tests.integration.SimpleTest` but extends `org.apache.activemq.artemis.tests.util.SingleServerTestBase` which eliminates all the setup and class variables which are provided by `SingleServerTestBase` itself.
39
+
https://github.com/apache/artemis/blob/main/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/SingleServerSimpleTest.java[`org.apache.activemq.artemis.tests.integration.SingleServerSimpleTest`] is an example based on `org.apache.activemq.artemis.tests.integration.SimpleTest` but extends `org.apache.activemq.artemis.tests.util.SingleServerTestBase` which eliminates all the setup and class variables which are provided by `SingleServerTestBase` itself.
40
40
41
41
== Writing Web Tests
42
42
@@ -102,4 +102,4 @@ In any case, `org.apache.activemq.artemis.core.config.Configuration` is a https:
102
102
=== Look at other test-cases
103
103
104
104
If you need ideas on how to configure something or test something try looking through the test-suite at other test-cases which may be similar.
105
-
This is one of the best ways to learn how the test-suite works and how you can leverage the testing infrastructure to test your particular case.
105
+
This is one of the best ways to learn how the test-suite works and how you can leverage the testing infrastructure to test your particular case.
Copy file name to clipboardExpand all lines: docs/user-manual/architecture.adoc
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -53,7 +53,7 @@ For more information on server configuration files see xref:configuration-index.
53
53
54
54
The broker is designed as a set of simple POJOs so if you have an application that requires messaging functionality internally, but you don't want to expose that as an independent, standalone broker, you can directly instantiate and embed a broker in your own application.
55
55
56
-
Read more about xref:embedding-activemq.adoc#embedding-{project-name-full-url}[embedding a broker].
56
+
Read more about xref:embedding-artemis.adoc#embedding-{project-name-full-url}[embedding a broker].
57
57
58
58
== Integrated with a Java/Jakarta EE application server
59
59
@@ -77,4 +77,4 @@ It is possible to talk to a JMS messaging system directly from an EJB, MDB or se
77
77
Note that all communication between EJB sessions or entity beans and Message Driven beans go through the adaptor and not directly to the broker.
78
78
79
79
The large arrow with the prohibited sign shows an EJB session bean talking directly to the the broker.
80
-
This is not recommended as you'll most likely end up creating a new connection and session every time you want to interact from the EJB, which is an anti-pattern.
80
+
This is not recommended as you'll most likely end up creating a new connection and session every time you want to interact from the EJB, which is an anti-pattern.
0 commit comments