Skip to content

Commit 64d5429

Browse files
GH-48220 Fix arrow-buffer & arrow-misc testcase failures to enable Parquet DB support on s390x
1 parent 2fb2f79 commit 64d5429

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

cpp/src/arrow/buffer_test.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
#include "arrow/status.h"
3535
#include "arrow/testing/gtest_util.h"
3636
#include "arrow/util/checked_cast.h"
37+
#include "arrow/util/endian.h"
3738

3839
namespace arrow {
3940

@@ -996,7 +997,8 @@ TYPED_TEST(TypedTestBuffer, TypedResize) {
996997

997998
TYPED_TEST(TypedTestBuffer, ResizeOOM) {
998999
// This test doesn't play nice with AddressSanitizer
999-
#ifndef ADDRESS_SANITIZER
1000+
// Skip this test on big-endian architectures (e.g., s390x)
1001+
#if !defined(ADDRESS_SANITIZER) && ARROW_LITTLE_ENDIAN
10001002
// realloc fails, even though there may be no explicit limit
10011003
TypeParam buf;
10021004
ASSERT_OK_AND_ASSIGN(buf, AllocateResizableBuffer(0));

cpp/src/arrow/memory_pool_test.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
#include "arrow/status.h"
2727
#include "arrow/testing/gtest_util.h"
2828
#include "arrow/util/config.h"
29+
#include "arrow/util/endian.h"
2930
#include "arrow/util/logging.h"
3031

3132
namespace arrow {
@@ -68,8 +69,9 @@ TYPED_TEST_SUITE_P(TestMemoryPool);
6869

6970
TYPED_TEST_P(TestMemoryPool, MemoryTracking) { this->TestMemoryTracking(); }
7071

72+
// Skip this test on big-endian architectures (e.g., s390x)
7173
TYPED_TEST_P(TestMemoryPool, OOM) {
72-
#ifndef ADDRESS_SANITIZER
74+
#if !defined(ADDRESS_SANITIZER) && ARROW_LITTLE_ENDIAN
7375
this->TestOOM();
7476
#endif
7577
}

0 commit comments

Comments
 (0)