-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix(batch-requests): the number of sub-responses does not match that of sub-requests #12779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hachi029
wants to merge
8
commits into
apache:master
Choose a base branch
from
hachi029:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re is any timeout sub request
…mber of sub requests
Baoyuantop
reviewed
Nov 27, 2025
nic-6443
approved these changes
Dec 9, 2025
Contributor
|
Hi @hachi029, could you merge the latest main branch to make CI pass? |
Contributor
Author
|
@Baoyuantop merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when there is any timeout sub request, the number of sub responses does not match the number of sub requests。
for example:
the batch-request with 2 sub requests
{"headers":{},"pipeline":[{"path":"/ok","method":"GET"},{"path":"/timeout","method":"GET"}]}there are 3 sub responses in the batch-response, with an extra empty json object '{}'
[{"status":200,"body":"ok","reason":"OK","headers":{"Connection":"keep-alive"}},{"status":504,"reason":"upstream timeout"},{}]Checklist