Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2988] Add more base info for the table detail page #2989

Merged
merged 7 commits into from
Jul 5, 2024

Conversation

tcodehuber
Copy link
Contributor

Why are the changes needed?

Close #2988.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added module:ams-server Ams server module module:ams-dashboard Ams dashboard module labels Jul 1, 2024
@XBaith
Copy link
Contributor

XBaith commented Jul 1, 2024

It is OK to display other dimensions of information under the title, but I have a small suggestion. The information under the current table title and the metrics column on the right are a lot of duplication. I think the information under the title can be simplified. For example, the last commit time, table size, file count, avg file size and other information can be placed on the right.

@tcodehuber
Copy link
Contributor Author

It is OK to display other dimensions of information under the title, but I have a small suggestion. The information under the current table title and the metrics column on the right are a lot of duplication. I think the information under the title can be simplified. For example, the last commit time, table size, file count, avg file size and other information can be placed on the right.

If the optimizing status, records and table format is remained under the current table title, is it OK or do you have any suggestion which else information can be displayed there?

@tcodehuber
Copy link
Contributor Author

It is OK to display other dimensions of information under the title, but I have a small suggestion. The information under the current table title and the metrics column on the right are a lot of duplication. I think the information under the title can be simplified. For example, the last commit time, table size, file count, avg file size and other information can be placed on the right.

@XBaith If the optimizing status, records and table format is remained under the current table title, is it OK or do you have any suggestion which else information can be displayed there?

@XBaith
Copy link
Contributor

XBaith commented Jul 2, 2024

@XBaith If the optimizing status, records and table format is remained under the current table title, is it OK or do you have any suggestion which else information can be displayed there?

That's ok for me.
We can display full table identifier as title, <catalog>.<database>.<table>
image

@tcodehuber tcodehuber requested a review from XBaith July 2, 2024 03:09
Copy link
Contributor

@zhangmo8 zhangmo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XBaith
Copy link
Contributor

XBaith commented Jul 2, 2024

I think some of the metrics under the table identifier that duplicate the right hand side detail metrics should be removed, WDYT?

@tcodehuber
Copy link
Contributor Author

tcodehuber commented Jul 2, 2024

I think some of the metrics under the table identifier that duplicate the right hand side detail metrics should be removed, WDYT?

frontend or backend code? Can you show me more details, thanks.

@XBaith
Copy link
Contributor

XBaith commented Jul 2, 2024

last commit time, table size, file count, avg file size

Front side, metrics: last commit time, table size, file count and avg file size can be removed from the title?

@tcodehuber
Copy link
Contributor Author

image

@tcodehuber
Copy link
Contributor Author

last commit time, table size, file count, avg file size

Front side, metrics: last commit time, table size, file count and avg file size can be removed from the title?

Updated.

Copy link
Contributor

@XBaith XBaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It's ok for me, do you have any suggestions? @zhoujinsong

@zhoujinsong
Copy link
Contributor

@tcodehuber Thanks for the contribution!

I'm wondering if Optimizing Status would be better. Optimizing highlights our continuous optimization capability, and here the status perfectly corresponds to the ongoing actions of continuous optimization.

@tcodehuber
Copy link
Contributor Author

@tcodehuber Thanks for the contribution!

I'm wondering if Optimizing Status would be better. Optimizing highlights our continuous optimization capability, and here the status perfectly corresponds to the ongoing actions of continuous optimization.

OK, I have followed your suggestion.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tcodehuber tcodehuber merged commit 329d920 into apache:master Jul 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module module:ams-server Ams server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Add more base info for the table detail page
4 participants