-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-2988] Add more base info for the table detail page #2989
Conversation
It is OK to display other dimensions of information under the title, but I have a small suggestion. The information under the current table title and the metrics column on the right are a lot of duplication. I think the information under the title can be simplified. For example, the last commit time, table size, file count, avg file size and other information can be placed on the right. |
If the optimizing status, records and table format is remained under the current table title, is it OK or do you have any suggestion which else information can be displayed there? |
@XBaith If the optimizing status, records and table format is remained under the current table title, is it OK or do you have any suggestion which else information can be displayed there? |
That's ok for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think some of the metrics under the table identifier that duplicate the right hand side detail metrics should be removed, WDYT? |
frontend or backend code? Can you show me more details, thanks. |
Front side, metrics: last commit time, table size, file count and avg file size can be removed from the title? |
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! It's ok for me, do you have any suggestions? @zhoujinsong
@tcodehuber Thanks for the contribution! I'm wondering if |
OK, I have followed your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Why are the changes needed?
Close #2988.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation