Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generating secrets without a data section in Helm charts #45140

Open
2 tasks done
andrii-korotkov-verkada opened this issue Dec 21, 2024 · 0 comments
Open
2 tasks done
Labels
area:helm-chart Airflow Helm Chart area:secrets kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet

Comments

@andrii-korotkov-verkada
Copy link

andrii-korotkov-verkada commented Dec 21, 2024

Description

Currently the secrets are either not included or included with a non-empty data section with some secret values. It'd be great to have an option to generate secrets but without any secret data included (e.g. to be deployed with ArgoCD).

Use case/motivation

The motivation is security - secrets shouldn't be committed to the repository which is used to manage ArgoCD manifests.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@andrii-korotkov-verkada andrii-korotkov-verkada added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Dec 21, 2024
@dosubot dosubot bot added area:helm-chart Airflow Helm Chart area:secrets labels Dec 21, 2024
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/airflow that referenced this issue Dec 22, 2024
Sometimes you don't want to include secret data in Git manifest
for security reasons, e.g. when storing manifests in Git and
deploying with ArgoCD.

However, you may still want to generate a secret itself and then
edit it's data section later, e.g. manually with kubectl.

Provide more options of generating the secret while keeping
backwards compatibility.

Helps with: apache#45140

Signed-off-by: Andrii Korotkov <[email protected]>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/airflow that referenced this issue Dec 22, 2024
Sometimes you don't want to include secret data in Git manifest
for security reasons, e.g. when storing manifests in Git and
deploying with ArgoCD.

However, you may still want to generate a secret itself and then
edit it's data section later, e.g. manually with kubectl.

Provide more options of generating the secret while keeping
backwards compatibility.

related: apache#45140

Signed-off-by: Andrii Korotkov <[email protected]>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/airflow that referenced this issue Dec 22, 2024
Sometimes you don't want to include secret data in Git manifest
for security reasons, e.g. when storing manifests in Git and
deploying with ArgoCD.

However, you may still want to generate a secret itself and then
edit it's data section later, e.g. manually with kubectl.

Provide more options of generating the secret while keeping
backwards compatibility.

related: apache#45140

Signed-off-by: Andrii Korotkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart area:secrets kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet
Projects
None yet
Development

No branches or pull requests

1 participant