Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

Plugin does not handle pull requests #26

Open
fehrnah opened this issue Feb 6, 2021 · 5 comments
Open

Plugin does not handle pull requests #26

fehrnah opened this issue Feb 6, 2021 · 5 comments

Comments

@fehrnah
Copy link

fehrnah commented Feb 6, 2021

When the drone pipeline is started following a pull request, the sonar analyzer is not called in pull request mode.

@SparrowOchon
Copy link

For PR decoration you need to get Sonarqube developer+. Or Community PR Decoration. This only works with git hosts that are supported by Sonarqube i.e Gitlab, Github ... etc.

@fehrnah
Copy link
Author

fehrnah commented Jun 6, 2021

Yes, I am using the community branch plugin for sonarqube.

When creating a new pull request on my git host (gitea), a PR job is started on drone and fails when reaching this plugin.

It's been a while, but if I recall correctly, a pull request flag needs to be set before analysis with the current and target branches.

@SparrowOchon
Copy link

If I'm not mistaken the PR Decoration plugin doesn't work with Gitea. Because Sonarqube has no support for it.

@fehrnah
Copy link
Author

fehrnah commented Jun 6, 2021

Yes, this is not about the decorator, this is about being able to look a the analysis manually.

Right now I can't compare two branches' analysis results and see, for example, if a bug is new or not.

https://docs.sonarqube.org/latest/analysis/pull-request/

@SparrowOchon
Copy link

SparrowOchon commented Jun 6, 2021

Oh, sorry seems I misunderstood. Looking at my Gitlab repos (Assuming you mean two master branches since that's the only branch supported by community), direct branch analysis has worked for me with Drone (including comparing diffs from branch changes) thus your build process may be breaking the branch analysis.

The only remotely similar problem I've seen is This. But this involves non-master branches and the use of additional plugins.

Sorry, I can't be of much help, but I hope you find the solution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants