Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better control in fzf searching #641

Open
khaosdoctor opened this issue Dec 17, 2024 · 2 comments
Open

Better control in fzf searching #641

khaosdoctor opened this issue Dec 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@khaosdoctor
Copy link

Is your feature already implemented in the latest master? No

Is your feature request related to a problem? Please describe.
Being able to use fzf with / to find tracks in the liked songs (gy), for example, is an awesome addition. The problem is that once searched, I can't do anything other than play the track. If I want to add the searched track to the queue, this is not possible because every command will be typed in the search field. I've tried C-space, change focus, but nothing works. The only key that works is enter, if I press C-space I'm thrown back at the top of my liked songs list.

Describe the solution you'd like
It would be nice if the fzf search for every page worked like the search page, e.g: press / a new field pops below the current playing song progress bar, you can type in and the list is being filtered as you type. But, as you press FocusNextPane you drop to the results list where you can apply the same commands as you would be able to in the liked songs list or the search results list

Describe alternatives you've considered
What I'm doing today is that I use the search page to search for the song I want, even though I know the song is already saved in my library and then I use Z to add to the queue.

Additional context
Version: 0.20.4
MacOS Sequoia 15.1.1
Installed through Cargo with all the features

@khaosdoctor khaosdoctor added the enhancement New feature or request label Dec 17, 2024
@aome510
Copy link
Owner

aome510 commented Dec 17, 2024

The only key that works is enter, if I press C-space I'm thrown back at the top of my liked songs list.

Yes, but it should show a popup for you to initiate an action on the selected track.

If I want to add the searched track to the queue, this is not possible because every command will be typed in the search field

No, not every command. Commands with key bindings control + {char} or alt + {char} still work in the search. FYI, AddSelectedItemToQueue does have a C-z (control+z) binding. You can also define your own keybindings for a command for it to work with search.

Search is intended to be interactive. The solution you'd like to see defeats that purpose

@khaosdoctor
Copy link
Author

khaosdoctor commented Dec 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants