-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D watershed #20
Comments
Hi Rory, |
Hi Andrzej, |
Hi Rory, |
Hi Andrzej, |
Thanks for the clarification! I agree, the inversion is just an implementation detail which doesn't really matter for the resulting segmentation. You're right, for a 3D watershed you would look at the 6 neighboring pixels in the x, y, and z directions. Are you interested in implementing this? You would probably need to modify the original watershed C function to look around over the whole stack. Ideally, this behavior could be toggled by a function argument to allow 2D watershed on each frame separately as it is now, e.g., for timelapse images, and switch to the 3D mode only for true XYZ stacks. Looking forward to hearing from you. Cheers, |
I am interested in implementing it, I think it would be a very cool thing to have in R. I just took a look at the watershed.cpp file and some of it is a bit beyond me. I've written Rcpp before but I've never worked with |
Thanks Rory! It would be really awesome if you could contribute some of your skills and time to improve the package. There is a good introduction to R's C interface by Hadley Wickham. The existing watershed function already contains all the tedious type conversions to get you started. Don't hesitate to contact me if you have any further questions. I will be happy to discuss with you any intermediate implementations, or provide advise in case you get stuck. Cheers, |
OK thanks. |
Great! Looking forward to hearing about the progress. |
Hi Andrzej, |
Hi Rory, |
Hi @aoles
I'd like watershed to work in 3D (on z-stacks). Right now I can run the function on a stack, but it seems to just perform watershed on each slice individually, rather than really recognizing 3D objects. I think I know how to implement this. Are you interested in receiving a pull-request for this? If so, I'll let you know how I think it should work.
Thanks as always,
Rory
The text was updated successfully, but these errors were encountered: