Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine how to make better use of overloads for RPC methods #32

Open
buffalojoec opened this issue Dec 20, 2023 · 0 comments
Open

Determine how to make better use of overloads for RPC methods #32

buffalojoec opened this issue Dec 20, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@buffalojoec
Copy link

Motivation

In many cases, such as defining parameters to functions that wrap over RPC methods, the optional configuration object, such as the many different configuration parameters supported by getBlock, can cause TypeScript a great deal of confusion when trying to accurately type-check.

In fact, it usually will not successfully type-check for heavily overloaded methods such as getBlock.

Details

At the moment, the proper approach is not yet known. However, we may need to investigate possibly re-working these overloads to be more friendly with TypeScript.

@buffalojoec buffalojoec added enhancement New feature or request help wanted Extra attention is needed labels Dec 20, 2023
@buffalojoec buffalojoec changed the title Determine how to Determine how to make better use of overloads for RPC methods Dec 20, 2023
@steveluscher steveluscher transferred this issue from solana-labs/solana-web3.js Dec 14, 2024
@steveluscher steveluscher transferred this issue from another repository Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant