Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include replacementBlockhash in the simulation result type when replaceRecentBlockhash is true #21

Open
steveluscher opened this issue Jun 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@steveluscher
Copy link
Collaborator

steveluscher commented Jun 27, 2024

In SimulateTransactionApi we only return innerInstructions in the response when the innerInstructions config property is true. It would be nice to do the same for replacementBlockhash so that you don't have to null-check it.

To do so with the current design of the types would require all of the overloads to be duplicated to handle that case, as they were in solana-labs/solana-web3.js#2868. That would yield 32 overloads and require that we increase this number. That, in turn, would harm performance, so in solana-labs/solana-web3.js#2870 we decided not to do it.

The job is to find a way to make this happen.

@steveluscher steveluscher added the enhancement New feature or request label Jun 27, 2024
@steveluscher steveluscher transferred this issue from solana-labs/solana-web3.js Dec 14, 2024
@steveluscher steveluscher transferred this issue from another repository Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant