Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable @typescript-eslint rules one at a time #13

Open
steveluscher opened this issue Oct 26, 2024 · 2 comments · Fixed by solana-labs/solana-web3.js#3691
Open

Re-enable @typescript-eslint rules one at a time #13

steveluscher opened this issue Oct 26, 2024 · 2 comments · Fixed by solana-labs/solana-web3.js#3691
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@steveluscher
Copy link
Collaborator

steveluscher commented Oct 26, 2024 •
edited
Loading

Create one PR for each of these rules re-enabled:

https://github.com/solana-labs/solana-web3.js/blob/612a4d8688fc2a481d24ec7f415701c6aa92c707/eslint.config.mjs#L9-L20

https://github.com/solana-labs/solana-web3.js/blob/612a4d8688fc2a481d24ec7f415701c6aa92c707/examples/react-app/eslint.config.mjs#L27-L30
@steveluscher steveluscher added enhancement New feature or request good first issue Good for newcomers labels Oct 26, 2024
@Chirag-S-Kotian
Copy link

assign this to me.

@steveluscher
Copy link
Collaborator Author

Hi @Chirag-S-Kotian – thanks for wanting to contribute! Feel free to start sending PRs; there's no need to have a single assignee here because there's not enough competition for this work. We appreciate you!

Dozie2001 referenced this issue in Dozie2001/solana-web3.js Nov 17, 2024
@Dozie2001
Fixes #3465
8ac0724
This was referenced Nov 17, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@kox kox mentioned this issue Dec 6, 2024
Merged
@steveluscher steveluscher linked a pull request Dec 6, 2024 that will close this issue
Enable rule @typescript-eslint/restrict-template-expressions and fix the only error solana-labs/solana-web3.js#3691
Merged
@kox kox mentioned this issue Dec 11, 2024
Closed
@steveluscher steveluscher transferred this issue from solana-labs/solana-web3.js Dec 14, 2024
@steveluscher steveluscher transferred this issue from another repository Dec 14, 2024
This was referenced Dec 14, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@steveluscher @Chirag-S-Kotian